Bug 406955 – media-video/avidemux - Please add opengl USE flag (depends automagically on QtOpenGL)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description ac.serbanescu 2012-03-05 08:33:44 UTC]

When compiling, Avidemux uses QtOpenGL if present, but there's no corresponding use flag to install it if it's not (leaving one to manually install it and recompile).

Reproducible: Always

[Comment 1 Ian Delaney (RETIRED) 2012-03-10 11:39:46 UTC]

Created attachment 304821 [details, diff]
ebuild patch for -2.5.6

looks like this.

[Comment 2 Samuli Suominen (RETIRED) 2012-03-10 11:58:06 UTC]

should be x11-libs/qt-opengl:4 with the :4 and this would still leave the automagic dependency since you didn't add any flag to control the build:

http://www.gentoo.org/proj/en/qa/automagic.xml

[Comment 3 Ian Delaney (RETIRED) 2012-03-10 13:39:37 UTC]

Created attachment 304833 [details, diff]
ebuild patch for -2.5.6 revised

# USE=opengl ebuild avidemux-2.5.6.ebuild clean install

was effective, however QA notices,

[Comment 4 Samuli Suominen (RETIRED) 2012-03-10 13:45:47 UTC]

Comment on attachment 304833 [details, diff]
ebuild patch for -2.5.6 revised

You said it was USE_OPENGL in CMakeLists.txt and I told you the correct matching function is cmake-utils_use_use, not cmake-utils_use

And since the package has USE="qt4", the USE="opengl" should be behind it

So bogus patch ...

[Comment 5 Ian Delaney (RETIRED) 2012-03-10 15:40:50 UTC]

Created attachment 304851 [details, diff]
ebuild patch for -2.5.6

set

[Comment 6 Samuli Suominen (RETIRED) 2012-03-10 15:43:44 UTC]

(In reply to comment #5)
> Created attachment 304851 [details, diff] [details, diff]
> ebuild patch for -2.5.6
> 
> set

Still wrong. The USE="opengl" is still not behind USE="qt4". This way USE="opengl -qt4" still pulls in Qt4 which isn't wanted here.

[Comment 7 Ian Delaney (RETIRED) 2012-03-10 15:59:47 UTC]

Created attachment 304853 [details, diff]
ebuild patch for -2.5.6

opengl put 'behind'

[Comment 8 Markos Chandras (RETIRED) 2012-03-10 17:32:07 UTC]

Patch tested and looks good

[Comment 9 Markos Chandras (RETIRED) 2012-03-11 09:55:44 UTC]

I withdraw my last comment. The patch is bad. Nothing prevents opengl useflag to be enabled ( and have zero meaning ) when qt4 is disabled. I will commit a better patch

[Comment 10 Markos Chandras (RETIRED) 2012-03-11 10:34:34 UTC]

After discussing this with Samuli, we agreed that the patch is acceptable ( however there was a typo in the patch which I fixed. ) The updated ebuilds is now in portage. Thanks