Bug 406061 – Please review Prefix changes for =net-misc/rsync-3.0.9

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jeremy Olexa (darkside) (RETIRED) 2012-02-27 19:13:39 UTC]

Created attachment 303523 [details, diff]
rsync-3.0.9 patch

Patch attached. mint patch seen here: http://overlays.gentoo.org/proj/alt/browser/trunk/prefix-overlay/net-misc/rsync/files/rsync-3.0.7-mint.patch

Thanks

[Comment 1 Robin Johnson 2012-02-27 19:19:48 UTC]

Is there some change missing?
I don't see how the @GENTOO_PORTAGE_EPREFIX@ changes to $FILESDIR get removed on a non-prefix system.

Other than that, +1 as a revbump

[Comment 2 Jeremy Olexa (darkside) (RETIRED) 2012-02-27 19:37:52 UTC]

Created attachment 303527 [details, diff]
rsync-3.0.9 patch, take 2

Ah. Yes. The eprefixify call was wrong. I was refactoring it from the prefix overlay and did a poor job.

Also, the mint patch was accepted upstream. Here is a better tested diff. Are you sure a revbump is desired? We accept the wishes of the maintainer but it will be a useless recompilation for (majority of) users.

[Comment 3 Robin Johnson 2012-02-27 20:07:05 UTC]

revbump is twofold:
1. rsync is fairly core in system and I want to make sure it's still EAPI2 available for now.
2. 3.0.9 has a stablereq open.

[Comment 4 Robin Johnson 2012-02-27 20:07:20 UTC]

rest of the changes with fixed eprefixy look good

[Comment 5 Jeremy Olexa (darkside) (RETIRED) 2012-02-27 20:17:14 UTC]

(In reply to comment #3)
> revbump is twofold:
> 1. rsync is fairly core in system and I want to make sure it's still EAPI2
> available for now.

Understood. I arbitraily choose EAPI3 instead of 4. Shall I make the revbump EAPI3 or 4?

> 2. 3.0.9 has a stablereq open.

Yea, I just opened it today :) No arches are added yet.

Overlooked issue: if the files are editted in place in FILESDIR, it breaks the previous versions. How shall I copy & rename them to your liking?

[Comment 6 SpanKY 2012-02-27 20:48:35 UTC]

what robin said

also, stable bug does have arches added

[Comment 7 Robin Johnson 2012-02-27 20:56:45 UTC]

(In reply to comment #5)
> (In reply to comment #3)
> > revbump is twofold:
> > 1. rsync is fairly core in system and I want to make sure it's still EAPI2
> > available for now.
> 
> Understood. I arbitraily choose EAPI3 instead of 4. Shall I make the revbump
> EAPI3 or 4?
Might as well go EAPI4.

> > 2. 3.0.9 has a stablereq open.
> 
> Yea, I just opened it today :) No arches are added yet.
> 
> Overlooked issue: if the files are editted in place in FILESDIR, it breaks the
> previous versions. How shall I copy & rename them to your liking?
Just add -$PF on the end

[Comment 8 Jeremy Olexa (darkside) (RETIRED) 2012-02-28 19:34:39 UTC]

+*rsync-3.0.9-r1 (28 Feb 2012)
+
+  28 Feb 2012; Jeremy Olexa <[e-mail]> +files/rsyncd.conf-3.0.9-r1,
+  +files/rsyncd.xinetd-3.0.9-r1, +rsync-3.0.9-r1.ebuild:
+  revision bump to support Gentoo Prefix. EAPI, KEYWORDS, EPREFIX/ED/EROOT
+  usage, new files in FILESDIR. Bug 406061

Thanks.