Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 399867 - games-action/minetest games-action/minetest_game: new ebuilds
Summary: games-action/minetest games-action/minetest_game: new ebuilds
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: Normal enhancement with 1 vote (vote)
Assignee: Gentoo Games
Whiteboard: [sunrise-overlay], [hasufell-overlay]
Keywords: EBUILD, InOverlay, PATCH
: 458476 (view as bug list)
Depends on:
Reported: 2012-01-23 17:58 UTC by neko259
Modified: 2014-08-04 11:17 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

minetest-0.4.20120320.ebuild (minetest-0.4.20120320.ebuild,910 bytes, text/plain)
2012-03-25 17:50 UTC, neko259
minetest-0.4_pre20120320.ebuild (minetest-0.4_pre20120320.ebuild,1.11 KB, text/plain)
2012-04-03 04:49 UTC, Julian Ospald
minetest-0.4_pre20120320-cmake.patch (minetest-0.4_pre20120320-cmake.patch,1018 bytes, patch)
2012-04-03 04:49 UTC, Julian Ospald
Details | Diff
minetest-0.4_pre20120320-sharepath.patch (minetest-0.4_pre20120320-sharepath.patch,847 bytes, patch)
2012-04-03 04:49 UTC, Julian Ospald
Details | Diff
minetest_game-0.4_pre20120408.ebuild (minetest_game-0.4_pre20120408.ebuild,645 bytes, text/plain)
2012-04-24 00:53 UTC, Julian Ospald
minetest-0.4_pre20120408.ebuild (minetest-0.4_pre20120408.ebuild,1.24 KB, text/plain)
2012-04-24 00:53 UTC, Julian Ospald
minetest-0.4_pre20120408-cmake.patch (minetest-0.4_pre20120408-cmake.patch,1018 bytes, patch)
2012-04-24 00:53 UTC, Julian Ospald
Details | Diff
minetest-0.4_pre20120408-sharepath.patch (minetest-0.4_pre20120408-sharepath.patch,845 bytes, patch)
2012-04-24 00:53 UTC, Julian Ospald
Details | Diff
minetest-0.4_pre20120408-jthread.patch (minetest-0.4_pre20120408-jthread.patch,542 bytes, patch)
2012-04-24 00:54 UTC, Julian Ospald
Details | Diff
minetest-0.4_pre20120408-lua.patch (minetest-0.4_pre20120408-lua.patch,742 bytes, patch)
2012-04-24 00:54 UTC, Julian Ospald
Details | Diff
ebuild for minetest-0.4.3 (minetest-0.4.3.ebuild,1.50 KB, text/plain)
2012-11-01 15:18 UTC, Vasiliy Yeremeyev
init-script (minetestserver.init,422 bytes, text/plain)
2012-11-01 15:19 UTC, Vasiliy Yeremeyev
data for minetest engine (minetest-data-9999.ebuild,694 bytes, text/plain)
2012-11-01 15:20 UTC, Vasiliy Yeremeyev
live ebuild for minetest (minetest-9999.ebuild,1.52 KB, text/plain)
2012-11-01 15:21 UTC, Vasiliy Yeremeyev

Note You need to log in before you can comment on or make changes to this bug.
Description neko259 2012-01-23 17:58:52 UTC
Add a new ebuild for Minetest 0.3.1 (latest stable) 0.4 dev snapshots versions and 9999 :)
Comment 1 neko259 2012-03-25 17:50:41 UTC
Created attachment 306625 [details]

Ebuild for the latest version of minetest.
Comment 2 neko259 2012-04-03 04:47:10 UTC
Added ebuilds to nektoo overlay.
Comment 3 Julian Ospald 2012-04-03 04:49:10 UTC
Created attachment 307581 [details]
Comment 4 Julian Ospald 2012-04-03 04:49:26 UTC
Created attachment 307583 [details, diff]
Comment 5 Julian Ospald 2012-04-03 04:49:39 UTC
Created attachment 307585 [details, diff]
Comment 6 Julian Ospald 2012-04-03 04:51:56 UTC
added to sunrise-overlay

available after review:;a=tree;f=games-action/minetest;hb=HEAD
Comment 7 Julian Ospald 2012-04-24 00:53:00 UTC
Created attachment 309883 [details]
Comment 8 Julian Ospald 2012-04-24 00:53:21 UTC
Created attachment 309885 [details]
Comment 9 Julian Ospald 2012-04-24 00:53:40 UTC
Created attachment 309887 [details, diff]
Comment 10 Julian Ospald 2012-04-24 00:53:55 UTC
Created attachment 309889 [details, diff]
Comment 11 Julian Ospald 2012-04-24 00:54:09 UTC
Created attachment 309891 [details, diff]
Comment 12 Julian Ospald 2012-04-24 00:54:27 UTC
Created attachment 309893 [details, diff]
Comment 13 Vasiliy Yeremeyev 2012-11-01 15:18:52 UTC
Created attachment 327946 [details]
ebuild for minetest-0.4.3
Comment 14 Vasiliy Yeremeyev 2012-11-01 15:19:58 UTC
Created attachment 327948 [details]
Comment 15 Vasiliy Yeremeyev 2012-11-01 15:20:49 UTC
Created attachment 327950 [details]
data for minetest engine
Comment 16 Vasiliy Yeremeyev 2012-11-01 15:21:38 UTC
Created attachment 327952 [details]
live ebuild for minetest
Comment 17 Julian Ospald 2012-11-01 16:27:06 UTC
(In reply to comment #13)
> Created attachment 327946 [details]
> ebuild for minetest-0.4.3

let me comment on a few things...

- license CCPL-Attribution-ShareAlike-3.0 is missing (cause the engine-part also installs a minimal set of textures/data)

- irrlicht is only a build-time dependency, not runtime
- gettext is only a build-time dependency, not runtime
- libpng is missing a slot (use slot :0 here, cause :1.2 does not even provide headers and is only there for backwardscompatibility. If a user only has :1.2 currently installed the build process would fail)
- dependency logic inconsistent if the user does not compile the client
- a few deps missing, like virtual/jpeg, media-libs/libvorbis or x11-libs/libXxf86vm

- games should not use a "client" useflag, rather a "dedicated" useflag (which is a global one too)
- "game" is actually an invalid useflag, cause it does not change the build process and would trigger a rebuild where none is necessary. Put things like that in an "elog" in "pkg_postinst()" phase

- afaik the build system prefers the static jthread library. We should not, that needs a patch.

ebuild/eclass logic:
- you have some wrong install destinations due to using DCMAKE_INSTALL_PREFIX=${GAMES_PREFIX}, e.g.
The build system let's you choose all the locations specifically. Avoid setting install-prefix, but rather use DCUSTOM_SHAREDIR and DCUSTOM_BINDIR
- user.eclass should be inherited explicitly when you use functions from it directly
- snapshot/tarballs are preferred over EGIT_COMMIT things, cause we have a real Manifest file then. You can use vcs-snapshot eclass for that which uses git-generated tarballs from github
- src_prepare has to go before src_configure
- games.eclass has to go last, always. That's policy. If you do that you have to keep in mind that it inherits base.eclass and that you have to explictly call cmake-utils_src_compile in src_compile() phase
- it's safer to make mycmakeargs a local var
- non-portage commands like "rm" have to be appended a "|| die"
also "-f" is discouraged and only wanted in some cases. We want to be sure that those dirs with bundles libs are removed, so we want an error if they are not
- mkdir -p "${D}/var/lib/minetest" and mkdir -p "${D}/etc/init.d" are wrong, don't do it. Create user and group in "pkg_setup()" instead and do the installation in "src_install()". Also use "fowners" instead of "chown".
- EROOT should usually only be used for pkg_* phases. It has no place in src_configure here

I didn't tinker much with the server things. Can we run that stuff in a screen/tmux session? That's usually better.

sidenote: I have minetest in my overlay
you can send pull requests or open an issue like adding the initscript, so we don't duplicate work
Comment 18 Vasiliy Yeremeyev 2012-11-02 22:20:34 UTC
Thank you for detailed explanation. I've sent you pull request.
Comment 19 Julian Ospald 2013-02-20 16:12:41 UTC
*** Bug 458476 has been marked as a duplicate of this bug. ***
Comment 20 Julian Ospald 2013-08-05 22:43:38 UTC
in portage