Created attachment 298875 [details] Discussion in #gentoo-dev The cdrom_* functions have been split out from eutils.eclass into a new cdrom.eclass. All ebuilds using these functions should be changed as follows: - Add cdrom to inherit line - Optionally, PROPERTIES=interactive can be removed because the eclass already sets it I'd commit these changed myself, but there were some objections against it, see attached IRC log. When all ebuilds are done, I'll remove the functions from eutils.eclass. List of all affected ebuilds in Portage tree: cjk: app-i18n/atokx2 app-i18n/atokx3 calchan, games: games-rpg/nwn-data games-rpg/sacred-gold tristan, games: games-action/heretic2 games-fps/etqw-data games-fps/postal2 vapier, games: games-fps/unreal-tournament-goty games-fps/unreal-tournament games-fps/unreal games: games-action/d1x-rebirth games-action/descent2-data games-action/descent3 games-action/fakk2 games-action/heavygear2 games-action/postalplus games-action/rune games-fps/doom3-data games-fps/doom3-roe games-fps/duke3d-data games-fps/quake1-data games-fps/quake2-data games-fps/quake3-data games-fps/quake3-teamarena games-fps/quake4-data games-fps/soldieroffortune games-fps/tribes2 games-fps/ut2003-data games-fps/ut2004-data games-strategy/coldwar games-strategy/darwinia games-strategy/dominions2 games-strategy/heroes3 games-strategy/smac games-strategy/wargus games-strategy/x2
Setting PROPERTIES="interactive" in the eclass is not such a good idea. Some ebuilds are only interactive with USE=cdinstall.
(In reply to comment #1) > Setting PROPERTIES="interactive" in the eclass is not such a good idea. > Some ebuilds are only interactive with USE=cdinstall. Good point, I wasn't aware of this. I've removed the line from the eclass.
(In reply to comment #2) > > Setting PROPERTIES="interactive" in the eclass is not such a good idea. > > Some ebuilds are only interactive with USE=cdinstall. > > Good point, I wasn't aware of this. I've removed the line from the eclass. Added again, but only conditionally executed, as suggested in -dev ML: <http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/cdrom.eclass?r1=1.2&r2=1.3>
The following are done, with permission from vapier and mr_bones_: games-action/d1x-rebirth games-action/descent2-data games-action/descent3 games-action/fakk2 games-action/heavygear2 games-action/postalplus games-action/rune games-fps/doom3-data games-fps/doom3-roe games-fps/duke3d-data games-fps/quake1-data games-fps/quake2-data games-fps/quake3-data games-fps/quake3-teamarena games-fps/quake4-data games-fps/soldieroffortune games-fps/tribes2 games-fps/unreal games-fps/unreal-tournament games-fps/unreal-tournament-goty games-fps/ut2003-data games-fps/ut2004-data games-strategy/coldwar games-strategy/darwinia games-strategy/dominions2 games-strategy/heroes3 games-strategy/smac games-strategy/wargus games-strategy/x2 Still missing: cjk: app-i18n/atokx2 app-i18n/atokx3 calchan, games: games-rpg/nwn-data games-rpg/sacred-gold tristan, games: games-action/heretic2 games-fps/etqw-data games-fps/postal2
> games-action/heretic2 > games-fps/etqw-data > games-fps/postal2 Done, with permission from tristan.
@CJK team, any objections if I commit the changes (as outlined in comment #0) for app-i18n/atokx{2,3} myself?
cjk guys tend to have high latency. just do it.
(In reply to comment #6) > @CJK team, any objections if I commit the changes (as outlined in comment #0) > for app-i18n/atokx{2,3} myself? Seems not. Done.
I've removed the cdrom functions from eutils.eclass. For the time being, eutils inherits cdrom; this can be removed as soon as the last two packages are migrated: calchan, games: games-rpg/nwn-data games-rpg/sacred-gold
(In reply to comment #9) > I've removed the cdrom functions from eutils.eclass. For the time being, eutils > inherits cdrom; Reverted. This can't be done because of PROPERTIES="interactive" in cdrom.eclass.
(In reply to comment #9) > calchan, games: > games-rpg/nwn-data > games-rpg/sacred-gold @Calchan: Any estimate when these will be fixed?
(In reply to comment #11) > (In reply to comment #9) > > calchan, games: > > games-rpg/nwn-data > > games-rpg/sacred-gold > > @Calchan: Any estimate when these will be fixed? No answer, so I've fixed these myself. Finally, cdrom functions removed from eutils.eclass.
