Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 398617 - [patch] app-admin/analog build fix
Summary: [patch] app-admin/analog build fix
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-12 07:05 UTC by Marcin Kowalski
Modified: 2012-03-04 10:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
ioapi.h patch (ioapi.patch,628 bytes, patch)
2012-01-12 07:06 UTC, Marcin Kowalski 		Details | Diff
unzip.h patch (unzip.patch,369 bytes, patch)
2012-01-12 07:06 UTC, Marcin Kowalski 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcin Kowalski 2012-01-12 07:05:48 UTC 
app-admin/analog fails on unzip subdirectory in the same way games-emulation/puae does. Based on puae bug report, ( #351652 )  i adapted the unzip.h patch for analog and it fixes the build.

Unlike puae, two files need to be patched : src/unzip/unzip.h and src/unzip/ioapi.h 

i'll attach my patches in a moment. please consider reviewing their validity.

Reproducible: Always

Steps to Reproduce:
1. try building app-admin/analog
2. it fails due to undefined OF macro
3. apply patches
4. it builds and works ; requires some extra testing to make 100% sure
Actual Results:  
it does not build

Expected Results:  
it builds and works
Comment 1 Marcin Kowalski 2012-01-12 07:06:17 UTC 
Created attachment 298719 [details, diff]
ioapi.h patch
Comment 2 Marcin Kowalski 2012-01-12 07:06:29 UTC 
Created attachment 298721 [details, diff]
unzip.h patch
Comment 3 Michael Weber (RETIRED) gentoo-dev 2012-01-29 02:05:10 UTC 
Hello,

thanks for your report. I cannot reproduce this on my Gentoo/Linux machine, so please attach an complete build.log (of the failing ebuild) and add your machines `emerge --info` to the comment.

Thank you.
Comment 4 Pacho Ramos gentoo-dev 2012-03-04 10:27:57 UTC 
+  04 Mar 2012; Pacho Ramos <pacho@gentoo.org>
+  +files/analog-6.0-undefined-macro.patch, analog-6.0-r4.ebuild:
+  Fix compilation, bug #398617 by Marcin Kowalski.
+