Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 398009 - repoman should not generate new ChangeLog entry when modifying Manifest
Summary: repoman should not generate new ChangeLog entry when modifying Manifest
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 402213
  Show dependency tree
 
Reported: 2012-01-07 12:21 UTC by Markos Chandras (RETIRED)
Modified: 2012-02-12 07:10 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markos Chandras (RETIRED) gentoo-dev 2012-01-07 12:21:35 UTC
Hi, today I tried to remanifest an ebuild (so the only file that changed was Manifest) but repoman generated a new ChangeLog entry (repoman commit -m). Imho this is not desired. remanifests should not be documented on the changelog ( nobody used to document remanifests as far as I remember). Could you please make repoman ignore that in the future? Thanks


+  07 Jan 2012; Markos Chandras <hwoarang@gentoo.org> Manifest:
+  remanifest
+
Comment 1 Zac Medico gentoo-dev 2012-01-07 12:42:20 UTC
Until this is fixed, use --echangelog=n when re-manifesting.
Comment 2 Fabian Groffen gentoo-dev 2012-01-07 12:47:08 UTC
I vaguely recall that this was done because the Council decided that all changes to a package should be recorded, and fixing the Manifest is also such one.  (echangelog did the same IIRC)
Comment 3 Markos Chandras (RETIRED) gentoo-dev 2012-01-07 12:50:46 UTC
(In reply to comment #2)
> I vaguely recall that this was done because the Council decided that all
> changes to a package should be recorded, and fixing the Manifest is also such
> one.  (echangelog did the same IIRC)

Fabian, I am 95% sure that remanifests were never documented (at least for the majority of devs) in the Changelog. It is a trivial change which does not need0 any sort of documentation on the Changelog. I think echangelog did not do that, it simply said something like "no changes spotted. Use --force to write a changelog anyway"
Comment 4 Fabian Groffen gentoo-dev 2012-01-07 12:53:10 UTC
I really don't care much.  I just think Portage should follow Council decisions.
Comment 5 Zac Medico gentoo-dev 2012-01-07 13:03:28 UTC
Bug 388997 seems to be complaining about the same behavior. I think it's reasonable skip ChangeLog generation when only the Manifest is modified, and allow --echangelog=force to for generation. Currently, --echangelog=force only applies to the case where the ChangeLog is already modified prior to calling repoman.
Comment 7 Zac Medico gentoo-dev 2012-02-12 07:10:05 UTC
This is fixed in 2.1.10.46 and 2.2.0_alpha86.