Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 388997 - sys-apps/portage (and echangelog): Automated ChangeLog generation has different behavior for Manifest file
Summary: sys-apps/portage (and echangelog): Automated ChangeLog generation has differe...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-30 17:03 UTC by Samuli Suominen
Modified: 2012-08-20 06:33 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Samuli Suominen gentoo-dev 2011-10-30 17:03:36 UTC
This doesn't look normal.   The behavior should match.   I'm not sure in which one the bug is, Portage or echangelog.

ssuominen@null ~/gentoo-x86/x11-terms/sakura $ echangelog "Regenerate Manifest wrt #388993 by Samuel BAUER"
**
** NOTE: No non-trivial changed files found.  Normally echangelog
** should be run after all affected files have been added and/or
** modified.  Did you forget to cvs add?
**
** In strict mode, exiting
** If you know what you're doing there pass '--no-strict' to echangelog
ssuominen@null ~/gentoo-x86/x11-terms/sakura $ repoman ci -m "Regenerate Manifest wrt #388993 by Samuel BAUER"

RepoMan scours the neighborhood...
>>> Creating Manifest for /home/ssuominen/gentoo-x86/x11-terms/sakura

Note: use --include-dev (-d) to check dependencies for 'dev' profiles


--- ./ChangeLog
+++ ./ChangeLog
@@ -4,0 +5,3 @@
+  30 Oct 2011; Samuli Suominen <ssuominen@gentoo.org> Manifest:
+  Regenerate Manifest wrt #388993 by Samuel BAUER
+

* 1 files being committed... 1 have headers that will change.
* Files with headers will cause the manifests to be changed and committed separately.

Using commit message:
------------------------------------------------------------------------------
Regenerate Manifest wrt #388993 by Samuel BAUER

(Portage version: 2.2.0_alpha71_p73/cvs/Linux x86_64)
------------------------------------------------------------------------------

/var/cvsroot/gentoo-x86/x11-terms/sakura/ChangeLog,v  <--  ChangeLog
new revision: 1.24; previous revision: 1.23
>>> Creating Manifest for /home/ssuominen/gentoo-x86/x11-terms/sakura

You need a passphrase to unlock the secret key for
user: "Samuli Suominen <ssuominen@gentoo.org>"
2048-bit RSA key, ID 4868F14D, created 2011-09-26

/var/cvsroot/gentoo-x86/x11-terms/sakura/Manifest,v  <--  Manifest
new revision: 1.30; previous revision: 1.29

Commit complete.
RepoMan sez: "If everyone were like you, I'd be out of business!"

ssuominen@null ~/gentoo-x86/x11-terms/sakura $
Comment 1 Samuli Suominen gentoo-dev 2011-10-30 18:04:56 UTC
=app-portage/gentoolkit-dev-0.2.8
=sys-apps/portage-9999 (checkout from yesterday)
Comment 2 Zac Medico gentoo-dev 2011-10-30 18:17:42 UTC
(In reply to comment #0)
> This doesn't look normal.   The behavior should match.   I'm not sure in which
> one the bug is, Portage or echangelog.
> 
> ssuominen@null ~/gentoo-x86/x11-terms/sakura $ echangelog "Regenerate Manifest
> wrt #388993 by Samuel BAUER"
> **
> ** NOTE: No non-trivial changed files found.  Normally echangelog
> ** should be run after all affected files have been added and/or
> ** modified.  Did you forget to cvs add?
> **
> ** In strict mode, exiting
> ** If you know what you're doing there pass '--no-strict' to echangelog

I think the echangelog --no-strict option will make it behave more like repoman.
Comment 3 Samuli Suominen gentoo-dev 2011-10-30 18:31:40 UTC
I don't care which one will be made the default, but one should be picked, and the default behavior needs to be consistent in both.
Comment 4 Fabian Groffen gentoo-dev 2011-10-31 17:56:47 UTC
IMO the only real solution to this is to teach repoman how to deal with eclass and profiles dirs.  This is desirable for other reasons as well.
Comment 5 Samuli Suominen gentoo-dev 2012-08-19 22:27:05 UTC
(In reply to comment #4)
> IMO the only real solution to this is to teach repoman how to deal with
> eclass and profiles dirs.  This is desirable for other reasons as well.

How is that related to this bug?

(In reply to comment #2)
> I think the echangelog --no-strict option will make it behave more like
> repoman.

So how about making --no-strict default then? The behaviours are still different after nearly a year. Can we at least decide which one should be changed? The tree is literally getting polluted by pointless Manifest -only ChangeLoge entries.
Comment 6 Zac Medico gentoo-dev 2012-08-19 22:38:54 UTC
(In reply to comment #5)
> The tree is literally getting polluted by pointless Manifest -only
> ChangeLoge entries.

Doesn't the change from bug 398009 help? Since that change, it will only generate a Manifest-only ChangeLog entry if you use --echangelog=force.
Comment 7 Fabian Groffen gentoo-dev 2012-08-20 06:33:56 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > IMO the only real solution to this is to teach repoman how to deal with
> > eclass and profiles dirs.  This is desirable for other reasons as well.
> 
> How is that related to this bug?

Then echangelog can go, which solves your "the tools differ in behaviour" problem.