Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 385879 - Search results are shown in <div id="leftcontent"> instead of middlecontent
Summary: Search results are shown in <div id="leftcontent"> instead of middlecontent
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Infrastructure
Classification: Unclassified
Component: [OLD] gpackages (show other bugs)
Hardware: All Linux
: Normal critical (vote)
Assignee: Gentoo Packages Website
URL: http://packages.gentoo.org
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-06 17:00 UTC by Peter Asplund
Modified: 2012-07-20 12:58 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix search results shown in middlecontent (0001-Fix-search-results-shown-in-middlecontent.patch,646 bytes, patch)
2012-04-11 17:36 UTC, Yanbo Wang
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Asplund 2011-10-06 17:00:34 UTC
When searching on packages.gentoo.org, the search results are shown in the left pane (leftcontent) instead of the center pane (middlecontent).

Screenshot here: http://tinypic.com/view.php?pic=23lgna&s=7
Comment 1 Anton Bolshakov 2011-10-25 05:45:04 UTC
I'm not sure if the above mentioned bug can fix it, but the rest of the search function is broken too:

1. Two search input fields with 2 search buttons
2. Enter button does work with the second field
3. Unnecessary (annoying) alert box with the message: "Running search for"

It has been broken for a month. Please fix it.
Comment 2 Peter Asplund 2012-01-30 12:19:19 UTC
I agree with previous commenter, and am still able to reproduce all points.
Comment 3 Yanbo Wang 2012-04-11 17:36:41 UTC
Created attachment 308543 [details, diff]
Fix search results shown in middlecontent

Add width and word-wrap(break-word) in style.css
Comment 4 Marcel Wiegand 2012-06-28 23:47:35 UTC
The search function is broken for a few months now.
It would be very simple to fix this problem.
So please fix it! Thanks!
Comment 5 Alec Warner (RETIRED) archtester gentoo-dev Security 2012-07-06 20:17:39 UTC
An hour of my time and much pleading by Zero Chaos, this should be fixed. I will go on record and state that I really hate javascript.

-A
Comment 6 Peter Asplund 2012-07-08 18:37:47 UTC
It's fixed! This is awesome! \o/
So much happiness for so few lines of code =)
Comment 7 Anton Bolshakov 2012-07-17 10:24:54 UTC
Alec, is it to much asking to focus that search field by default?


ps. Thanks for fixing the main issue. I'm using that search almost everyday and that bug was a big pain.
Comment 8 Alec Warner (RETIRED) archtester gentoo-dev Security 2012-07-17 11:16:42 UTC
(In reply to comment #7)
> Alec, is it to much asking to focus that search field by default?

Assume that I know nothing about web development at all; how do I make the search box have focus with javascript? :)

-A

> 
> 
> ps. Thanks for fixing the main issue. I'm using that search almost everyday
> and that bug was a big pain.
Comment 9 Peter Asplund 2012-07-17 12:12:19 UTC
I can comment on that one =)

http://www.mediacollege.com/internet/javascript/form/focus.html
Comment 10 Anton Bolshakov 2012-07-17 14:43:56 UTC
(In reply to comment #9)
> I can comment on that one =)

Practically, it's not a pure javascript.
The script is provided by google and it might not have that function by default

I'm currently looking at
http://code.google.com/apis/ajax/playground/#custom_search_control
http://www.technologytoolbox.com/blog/jjameson/archive/2012/02/02/building-technologytoolbox-com-part-21.aspx

So trick might be to call searchBox.focus(); method from configureSearchBox function (instead of searchBox.val("Search..."); )
Comment 11 Peter Asplund 2012-07-18 11:59:33 UTC
The "OnLoad=" and .focus() is a part of standard HTML/JS I think, so it's worth a shot. The thing it does is to tell the browser where to put the focus after loading the page, so I guess it should work.
But whatever does the trick is good enough for me!

I can't say I like the new Google functionality though. Ugly search results plus it automatically opens links in a new window (something I choose to do myself by using middle-click).

Perhaps the option to switch to znurt should be re-iterated (depending on how hard it would be).
Comment 12 Alec Warner (RETIRED) archtester gentoo-dev Security 2012-07-18 12:06:55 UTC
(In reply to comment #11)
> The "OnLoad=" and .focus() is a part of standard HTML/JS I think, so it's
> worth a shot. The thing it does is to tell the browser where to put the
> focus after loading the page, so I guess it should work.
> But whatever does the trick is good enough for me!
> 
> I can't say I like the new Google functionality though. Ugly search results
> plus it automatically opens links in a new window (something I choose to do
> myself by using middle-click).

new? Its been this way for years. We can the make the results prettier if someone wants to style them. This thing is mostly in maintenance mode though, so I can only fix bugs, not add features.

> 
> Perhaps the option to switch to znurt should be re-iterated (depending on
> how hard it would be).

Nothing stops you from using it :)

-A
Comment 13 Peter Asplund 2012-07-20 11:27:06 UTC
I've been using the old search box when searching (there were two before), So perhaps that's why I haven't seen the "new" way of presenting the results.

Just a question out of curiosity, how many visits does the site get per day?
Comment 14 Alec Warner (RETIRED) archtester gentoo-dev Security 2012-07-20 12:58:54 UTC
(In reply to comment #13)
> I've been using the old search box when searching (there were two before),
> So perhaps that's why I haven't seen the "new" way of presenting the results.

Ahh.

> 
> Just a question out of curiosity, how many visits does the site get per day?

150k / day including bots / search engines / whatnot.
100k / day for human-only traffic.

-A