Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 383899 - gnome2.eclass should reuse .la punting code from eutils.eclass
Summary: gnome2.eclass should reuse .la punting code from eutils.eclass
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: gnome2.eclass 383901
  Show dependency tree
 
Reported: 2011-09-21 09:31 UTC by Michał Górny
Modified: 2012-11-17 13:04 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-09-21 09:31:38 UTC
We have improved .la punting in autotools-utils lately and it is way better than it used to be. It doesn't rely on random USE flags but on real filesystem state, and it tries to smartly remove unnecessary .la files. It'd be great if gnome2 could reuse autotools-utils.
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2012-04-14 18:35:08 UTC
It is not possible to reuse that eclass since it does not support EAPI < 2.
The best we could do is to copy/paste the code :(, it that what you are suggesting ?
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-04-14 18:52:40 UTC
Well, I was thinking mostly about the eclass but you still can take a look if you want to.

By the way, do you really want to support ancient EAPIs that long? I don't think there's a real benefit from it, and GNOME is probably alive enough to get things bumped.
Comment 3 Gilles Dartiguelongue (RETIRED) gentoo-dev 2012-04-14 19:20:12 UTC
(In reply to comment #2) 
> By the way, do you really want to support ancient EAPIs that long? I don't
> think there's a real benefit from it, and GNOME is probably alive enough to
> get things bumped.

I don't really care, but it would be annoying to update all the ebuilds still using older EAPIs. Plus I don't remember the outcome of the last discussion on eclass API breakage on gentoo-dev :(
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-04-14 19:25:54 UTC
Well, there's no hurry. I'd just suggest bumping EAPIs on package bumps. That usually helps a lot keeping the tree up-to-date.
Comment 5 Pacho Ramos gentoo-dev 2012-04-15 10:02:29 UTC
(In reply to comment #4)
> Well, there's no hurry. I'd just suggest bumping EAPIs on package bumps.
> That usually helps a lot keeping the tree up-to-date.

I try to bump eapi on every change/bump but there are still old packages using old eapis. Maybe the way to go would be to use that eclass for eapi >=2 and copy that function to gnome2.eclass for older eapis (to finally drop this compat when there are 0 ebuilds using gnome2.eclass and old eapis)
Comment 6 Pacho Ramos gentoo-dev 2012-06-06 16:17:20 UTC
now, eapi problem should be gone, but I doubt between how to handle "--all" option for prune_libtool_files function, as we are currently having ebuilds that would fit on "--all" (most) but a few of them (like libgphoto2) that rely on .la files.
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-06-06 16:43:25 UTC
(In reply to comment #6)
> now, eapi problem should be gone, but I doubt between how to handle "--all"
> option for prune_libtool_files function, as we are currently having ebuilds
> that would fit on "--all" (most) but a few of them (like libgphoto2) that
> rely on .la files.

--all is mostly for plugins. Usually, the function should handle everything; if it doesn't, feel free to report and I'll try to improve it.
Comment 8 Pacho Ramos gentoo-dev 2012-06-06 17:09:49 UTC
There are two options also:
- Keep GNOME2_LA_PUNT variable, that would drop .la files always (as currently done, depending on static-libs USE)
- Deprecate GNOME2_LA_PUNT and always call prune_libtool_files: shouldn't hurt as we have "lafilefixer" and "fixlafiles" portage FEATUREs but, as this would affect all ebuilds inheriting gnome2.eclass without a revbump... 

Anyway, if eapi5 is near, we would surely default to run prune_libtool_files always for that eapi, but no idea about package managers handling that removal themselves :/
Comment 9 Pacho Ramos gentoo-dev 2012-11-17 13:04:02 UTC
+  17 Nov 2012; Pacho Ramos <pacho@gentoo.org> gnome2.eclass:
+  Rely on prune_libtool_files for eapis >= 5 as discussed with the team via
+  mail.
+