Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 379801 - app-emulation/wine has automagic build-time dependency on sys-devel/prelink
Summary: app-emulation/wine has automagic build-time dependency on sys-devel/prelink
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Wine Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-18 22:47 UTC by Bartosz Brachaczek
Modified: 2011-11-04 09:00 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bartosz Brachaczek 2011-08-18 22:47:30 UTC
app-emulation/wine should have optional build-time dependency on sys-devel/prelink. I imagine it could be controlled through a USE flag. See http://wiki.winehq.org/Prelink. Configuration process still warns about lack of prelink in Wine 1.3.26, so I believe that wiki page is still up to date.
The only potential problem I see is that I'm not sure if it's configurable to force Wine not to fix itself with prelink even if prelink is installed but the USE flag is turned off.
Comment 1 Maxim Koltsov (RETIRED) gentoo-dev 2011-08-19 21:42:54 UTC
(In reply to comment #0)
> The only potential problem I see is that I'm not sure if it's configurable to
> force Wine not to fix itself with prelink even if prelink is installed but the
> USE flag is turned off.
This is probably case of so-called automagic, read this please http://www.gentoo.org/proj/en/qa/automagic.xml
Comment 2 Bartosz Brachaczek 2011-08-19 21:57:05 UTC
Yes, I thought that only run-time dependencies can be called automagic. But that case fits perfectly to this definition:

> The so-called automagic dependencies are shallow dependencies
> of a software recognized at build or runtime and changes the way
> the software works".

So I'm changing summary to reflect that.
Comment 3 SpanKY gentoo-dev 2011-08-20 19:22:47 UTC
added prelink to DEPEND for all ebuilds.  seems wine has been invoking it since 2005, but no one ever noticed.
Comment 4 avx 2011-08-21 01:46:59 UTC
(In reply to comment #3)
> added prelink to DEPEND for all ebuilds.  seems wine has been invoking it since
> 2005, but no one ever noticed.

If (practically) no one - including me - ever noticed it, why do you see the need to force dep prelink now? It worked for years without it, according to the .ebuild, it still works without it (!hardened), so why not some USE-flag?
Comment 5 Andrew Savchenko gentoo-dev 2011-08-27 17:50:31 UTC
I vote for a separate prelink USE flag too.

When prelink is installed, portage will automatically use it for the whole system: according to http://www.gentoo.org/doc/en/prelink-howto.xml "Portage will automatically support prelink if it can find the prelink binary.". I do not want that. If prelink will be used only for wine internal libraries, that's ok with me, but to alter whole system due to portage's prelink automagick is not the case at all.

Well, ATM "hardened" may be used as that flag, but this is confusing and isn't a proper solution.
Comment 6 Bartosz Brachaczek 2011-08-27 18:02:11 UTC
I think you'd do better by reporting new bug rather than commenting on this one.
Comment 7 Andrew Savchenko gentoo-dev 2011-08-29 11:16:01 UTC
On second thought there are two bugs here:

1) prelink is optional dependency for wine; I opened bug 381033 for that.

2) portage should not automagically use prelink without ability of user control via FEATURES flags. 

Well, gentoo prelink guide is really obscure and I can't understand how portage uses prelink. What I want to is to not prelink binaries automatically. According to bug 84109, it doesn't, but that post is six years old...

ATM I can't understand how portage handles prelink, so I will not report this as a bug yet. But it looks like for me as automagic prelink usage in portage.
Comment 8 i.Dark_Templar 2011-10-22 17:56:03 UTC
Why this bug is closed as "won't fix"? Is it THAT hard to make IUSE="+prelink"?
Comment 9 i.Dark_Templar 2011-10-22 17:57:20 UTC
Sorry, wrong bug report. Talked about bug #381033 in another tab.
Comment 10 Naohiro Aota gentoo-dev 2011-11-04 09:00:10 UTC
prelink depends on glibc headers, and so this change break Gentoo/FreeBSD or such.
I'll change it to "!hardened ( elibc_glibc? ( sys-devel/prelink ) )"