Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 378597 - net-print/cups-1.4.6-r2 and cups-1.5-rc1 garble large graphics files
Summary: net-print/cups-1.4.6-r2 and cups-1.5-rc1 garble large graphics files
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Printing (show other bugs)
Hardware: x86 Linux
: Normal normal (vote)
Assignee: Printing Team
URL: http://www.cups.org/newsgroups.php?s1...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-10 03:06 UTC by Ted Marston
Modified: 2011-08-28 23:21 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ted Marston 2011-08-10 03:06:44 UTC
A simple programming error in filter/image.c : flush_tile() fails to open the image cachefile and save dirty image tiles before deleting their stale data. This only happens with LARGE images (.PNG etc) that need to use the cache. The above URL gives an example (not mine). The fix is simple:
diff filter/image.c.Orig filter/image.c
636c636
<   if (img->cachefile < 0)
---
>   if (img->cachefile == 0)


Reproducible: Always

Steps to Reproduce:
1. Generate large image file, e.g. 10Mbytes, of .PNG or .PPM data
2. Send it to printer
Actual Results:  
Image is cut up into blocks and some are repeated over the printout, some are missing. 


I've tried to report this up-stream but response is slow. Its such a simple fix that must affect many and is so annoying that I thought it worth trying to get the patch added to the next ebuilds for cups.
Comment 1 Timo Gurr (RETIRED) gentoo-dev 2011-08-26 10:29:36 UTC
(In reply to comment #0)
> I've tried to report this up-stream but response is slow. Its such a simple fix
> that must affect many and is so annoying that I thought it worth trying to get
> the patch added to the next ebuilds for cups.

If it's still an issue with CUPS 1.4.8 and 1.5.0 could you please link the URL to the upstream bugreport so we can track the progress?
Comment 2 Ted Marston 2011-08-26 22:38:02 UTC
I think this is what your looking for, it's not my fix, but has the same effect:-

   http://www.cups.org/str.php?L3901

It should appear in CUPS-1.5.1
Comment 3 Andreas K. Hüttel archtester gentoo-dev 2011-08-28 23:21:19 UTC
Fixed in 1.4.8-r22 and 1.5.0-r2