Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 376021 - [patch] net-print/cups should provide systemd support
Summary: [patch] net-print/cups should provide systemd support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Printing (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Printing Team
URL: http://cups.org/str.php?L3917
Whiteboard: tracking upstream
Keywords: PATCH
Depends on:
Blocks: systemd-consumers
  Show dependency tree
 
Reported: 2011-07-22 17:16 UTC by Alec Moskvin
Modified: 2012-01-28 20:43 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
cups-1.4.6-systemd.patch (cups-1.4.6-systemd.patch,35.02 KB, patch)
2011-07-22 17:18 UTC, Alec Moskvin
Details | Diff
Patch to cups-1.4.6-r21.ebuild (cups-1.4.6-r21.patch,1.42 KB, patch)
2011-07-22 17:19 UTC, Alec Moskvin
Details | Diff
cups-1.4.6-r21.ebuild with patch applied (cups-1.4.6-r21.ebuild,8.46 KB, text/plain)
2011-07-22 17:20 UTC, Alec Moskvin
Details
Updated patch (from upstream bug) (cups-systemd-socket.patch,12.38 KB, patch)
2012-01-28 20:34 UTC, Michał Górny
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Moskvin 2011-07-22 17:16:20 UTC
Please add the patch (by systemd creator Lennart Poettering) that adds systemd support and enables socket activation.

http://0pointer.de/blog/projects/socket-activation2.html

Reproducible: Always
Comment 1 Alec Moskvin 2011-07-22 17:18:22 UTC
Created attachment 280643 [details, diff]
cups-1.4.6-systemd.patch

Patch by Lennart Poettering
Comment 2 Alec Moskvin 2011-07-22 17:19:18 UTC
Created attachment 280645 [details, diff]
Patch to cups-1.4.6-r21.ebuild
Comment 3 Alec Moskvin 2011-07-22 17:20:05 UTC
Created attachment 280647 [details]
cups-1.4.6-r21.ebuild with patch applied
Comment 4 Alec Moskvin 2011-07-22 17:26:23 UTC
I'm not sure what the policy is in regards to patches, so I systemd support made it optional in the ebuild.


To once installed, cups can be enabled in systemd with socket activation, so it only starts when needed:
# systemctl enable cups.socket
# systemctl enable cups.path

or the usual way, so it starts during boot up:
# systemctl enable cups.service
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-08-09 11:51:20 UTC
Was that patch submitted upstream? I don't see it anywhere on their bugthingie.
Comment 6 yegle 2011-09-09 10:35:29 UTC
(In reply to comment #5)
> Was that patch submitted upstream? I don't see it anywhere on their bugthingie.

http://cups.org/str.php?L3917

These patches are not liked be accepted by upstream very soon.
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-09-09 13:08:14 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > Was that patch submitted upstream? I don't see it anywhere on their bugthingie.
> 
> http://cups.org/str.php?L3917
> 
> These patches are not liked be accepted by upstream very soon.

I submitted them myself. And upstream is likely to accept them; sadly, patch author is hardly reachable and probably unlike to sign their stupid agreement.
Comment 8 Alec Moskvin 2011-09-09 20:19:44 UTC
(In reply to comment #7)
> I submitted them myself. And upstream is likely to accept them; sadly, patch
> author is hardly reachable and probably unlike to sign their stupid agreement.

You should ask on the mailing list - Lennart is very active there...

http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Comment 9 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-09-09 21:43:11 UTC
(In reply to comment #8)
> (In reply to comment #7)
> > I submitted them myself. And upstream is likely to accept them; sadly, patch
> > author is hardly reachable and probably unlike to sign their stupid agreement.
> 
> You should ask on the mailing list - Lennart is very active there...
> 
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Could you do that? I'd appreciate.
Comment 10 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-01-07 22:18:31 UTC
The upstream process seems stalled. Maybe we should get their latest patch and apply it locally?
Comment 11 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-01-28 20:34:00 UTC
Created attachment 300199 [details, diff]
Updated patch (from upstream bug)
Comment 12 Andreas K. Hüttel archtester gentoo-dev 2012-01-28 20:43:35 UTC
Patch added in cups-1.5.0-r4, thanks!