Bug 376021 – [patch] net-print/cups should provide systemd support

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Alec Moskvin 2011-07-22 17:16:20 UTC]

Please add the patch (by systemd creator Lennart Poettering) that adds systemd support and enables socket activation.

http://0pointer.de/blog/projects/socket-activation2.html

Reproducible: Always

[Comment 1 Alec Moskvin 2011-07-22 17:18:22 UTC]

Created attachment 280643 [details, diff]
cups-1.4.6-systemd.patch

Patch by Lennart Poettering

[Comment 2 Alec Moskvin 2011-07-22 17:19:18 UTC]

Created attachment 280645 [details, diff]
Patch to cups-1.4.6-r21.ebuild

[Comment 3 Alec Moskvin 2011-07-22 17:20:05 UTC]

Created attachment 280647 [details]
cups-1.4.6-r21.ebuild with patch applied

[Comment 4 Alec Moskvin 2011-07-22 17:26:23 UTC]

I'm not sure what the policy is in regards to patches, so I systemd support made it optional in the ebuild.


To once installed, cups can be enabled in systemd with socket activation, so it only starts when needed:
# systemctl enable cups.socket
# systemctl enable cups.path

or the usual way, so it starts during boot up:
# systemctl enable cups.service

[Comment 5 Michał Górny 2011-08-09 11:51:20 UTC]

Was that patch submitted upstream? I don't see it anywhere on their bugthingie.

[Comment 6 yegle 2011-09-09 10:35:29 UTC]

(In reply to comment #5)
> Was that patch submitted upstream? I don't see it anywhere on their bugthingie.

http://cups.org/str.php?L3917

These patches are not liked be accepted by upstream very soon.

[Comment 7 Michał Górny 2011-09-09 13:08:14 UTC]

(In reply to comment #6)
> (In reply to comment #5)
> > Was that patch submitted upstream? I don't see it anywhere on their bugthingie.
> 
> http://cups.org/str.php?L3917
> 
> These patches are not liked be accepted by upstream very soon.

I submitted them myself. And upstream is likely to accept them; sadly, patch author is hardly reachable and probably unlike to sign their stupid agreement.

[Comment 8 Alec Moskvin 2011-09-09 20:19:44 UTC]

(In reply to comment #7)
> I submitted them myself. And upstream is likely to accept them; sadly, patch
> author is hardly reachable and probably unlike to sign their stupid agreement.

You should ask on the mailing list - Lennart is very active there...

http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[Comment 9 Michał Górny 2011-09-09 21:43:11 UTC]

(In reply to comment #8)
> (In reply to comment #7)
> > I submitted them myself. And upstream is likely to accept them; sadly, patch
> > author is hardly reachable and probably unlike to sign their stupid agreement.
> 
> You should ask on the mailing list - Lennart is very active there...
> 
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Could you do that? I'd appreciate.

[Comment 10 Michał Górny 2012-01-07 22:18:31 UTC]

The upstream process seems stalled. Maybe we should get their latest patch and apply it locally?

[Comment 11 Michał Górny 2012-01-28 20:34:00 UTC]

Created attachment 300199 [details, diff]
Updated patch (from upstream bug)

[Comment 12 Andreas K. Hüttel 2012-01-28 20:43:35 UTC]

Patch added in cups-1.5.0-r4, thanks!