Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 374233 - make QA notice more nice
Summary: make QA notice more nice
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Interface (emerge) (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 381649
  Show dependency tree
 
Reported: 2011-07-06 14:02 UTC by Toralf Förster
Modified: 2011-10-04 02:24 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2011-07-06 14:02:40 UTC
I sometimes do report messages like :



 * QA Notice: Package has poor programming practices which may compile
 *            fine but exhibit random runtime failures.
 * xxx

 * Please do not file a Gentoo bug and instead report the above QA
 * issues directly to the upstream developers of this software.
 * Homepage: http://x.y.z



to the appropriate sides. It least one time a dev was annoyed by the word "poor", maybe we can lower the message to something like :


QA Notice: Package may compile fine but may exhibit random runtime failures.


?

Reproducible: Always
Comment 1 Zac Medico gentoo-dev 2011-07-10 03:33:57 UTC
(In reply to comment #0)
> It least one time a dev was annoyed by the word

If they take offense to that then they're too sensitive. I think "poor programming practices" is a reasonable way to describe it. Maybe "questionable programming practices" would be a less harsh way of putting it.
Comment 2 SpanKY gentoo-dev 2011-07-10 05:14:27 UTC
i might be reaching, but i think there are cases where the code builds fine, but then an external library changes, and what used to compile cleanly now has warnings and hits the warning in question.

and even if developers have sh*tty practices, they dont like being told so.  telling them the blunt truth doesnt gain us, but perhaps slightly more "PC" wording will ?

(yes, i know i'm the source of the original language, and the intended target was people with sh*tty practices, but some people simply arent aware ...)
Comment 3 Toralf Förster gentoo-dev 2011-09-18 17:16:20 UTC
(In reply to comment #2)
 (yes, i know i'm the source of the original language ...)
Does this mean it is up to you to change that ?
Comment 4 Zac Medico gentoo-dev 2011-09-18 20:42:45 UTC
I've fixed it to refer to "severe warnings" instead of "poor programming":

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=62da1be30a7b9a9d550e63a18f0c6736f0801b59
Comment 5 Zac Medico gentoo-dev 2011-09-19 04:45:35 UTC
This is fixed in 2.1.10.19 and 2.2.0_alpha59.
Comment 6 Toralf Förster gentoo-dev 2011-09-19 12:33:42 UTC
Although it might be OT here this link http://bugs.ghostscript.com/show_bug.cgi?id=692515 is a current example that this feature is useful :-)