Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 374099 - Recent changes in libtool.eclass made elibtoolize useless with non-GNU find
Summary: Recent changes in libtool.eclass made elibtoolize useless with non-GNU find
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal major (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 384157
  Show dependency tree
 
Reported: 2011-07-05 04:47 UTC by Alexis Ballier
Modified: 2011-09-23 04:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Ballier gentoo-dev 2011-07-05 04:47:11 UTC
the -printf option to find doesnt exist with FreeBSD's find and thus elibtoolize finds nothing to patch... (and this changes the soname of almost every single library built with libtool on g/fbsd)

following patch should provide the same functionality:

Index: libtool.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/libtool.eclass,v
retrieving revision 1.93
diff -u -B -r1.93 libtool.eclass
--- libtool.eclass	10 Jun 2011 16:17:57 -0000	1.93
+++ libtool.eclass	5 Jul 2011 04:44:00 -0000
@@ -173,7 +173,7 @@
 	if [[ ${do_shallow} == "yes" ]] ; then
 		[[ -f ${S}/ltmain.sh ]] && set -- "${S}"
 	else
-		set -- $(find "${S}" -name ltmain.sh -printf '%h ')
+		set -- $(find "${S}" -name ltmain.sh -exec dirname {} \; | tr '\n' ' ')
 	fi
 
 	local d p
Comment 1 SpanKY gentoo-dev 2011-07-05 05:17:41 UTC
i dont know why we still havent made GNU find part of the ebuild env.  we keep hitting this useless thrashing in the tree.
Comment 2 Alexis Ballier gentoo-dev 2011-07-05 15:16:28 UTC
????

since when portability is a useless trashing ? or did you forget the 'IMHO' part ? :)
Comment 3 Alexis Ballier gentoo-dev 2011-07-05 16:44:10 UTC
OTOH, findutils doesnt build because of the --without-included-regex that requires a bit more than the POSIX spec of regex.h (like re_match); removing the switch I get a working, g-prefixed GNU find
Comment 4 SpanKY gentoo-dev 2011-07-05 20:31:43 UTC
(In reply to comment #2)

portability within the ebuild env is a waste of time.  using GNU extensions saves a lot more than attempting to be portable, and keeps bugs like this from ever cropping up.

(In reply to comment #3)

i think in the end this has been more headache than it was worth, so we probably can just punt it like we did with `sed`.
Comment 5 Alexis Ballier gentoo-dev 2011-07-05 20:42:48 UTC
(In reply to comment #4)
> (In reply to comment #2)
> 
> portability within the ebuild env is a waste of time.  using GNU extensions
> saves a lot more than attempting to be portable, and keeps bugs like this from
> ever cropping up.
> 
> (In reply to comment #3)
> 
> i think in the end this has been more headache than it was worth, so we
> probably can just punt it like we did with `sed`.

well, if findutils works it should be indeed easy and simpler to (at least) force it in ebuild env for the BSD's.
Comment 6 SpanKY gentoo-dev 2011-07-05 21:07:48 UTC
ive pushed out 4.4.2-r1 and 4.5.10-r1 with that flag dropped

this isnt something i want to special case BSD guys for ... the PMS spec will have to be updated to spell this out.
Comment 7 Alexis Ballier gentoo-dev 2011-07-05 21:16:35 UTC
(In reply to comment #6)
> ive pushed out 4.4.2-r1 and 4.5.10-r1 with that flag dropped
> 
> this isnt something i want to special case BSD guys for ... the PMS spec will
> have to be updated to spell this out.

bsd part done, we now use gfind & gxargs in ebuild env

feel free to push it to the pms if you wish so