Bug 373669 – sys-apps/portage-2.2.0_alpha41's repoman commit does not support VisualHostKey=yes in ssh_config

• Status: RESOLVED FIXED
• Product: Portage Development

[Description Nathan Phillip Brink (binki) (RETIRED) 2011-07-01 03:48:51 UTC]

This is probably not worth fixing, but definitely confused me the first time I saw it. Perhaps CVS is unreliable and in some circumstances reports errors to stderr and still returns 0. But in the following case, CVS exits successfully with no error and not outputting anything erroneously. But repoman commit doesn't think so.

Maybe the best fix, an alternative to accepting the VisualHostKey=yes output, is to forcibly VisualHostKey=no to SSH. But I can't figure out how to cleanly ask CVS to invoke SSH with the extra `-o VisualHostKey=no' arguments. Or perhaps recognizing the output and recommending the user disabled VisualHostKeys.

ohnobinki@ohnopublishing ~/gentoo-x86/dev-libs/liblist $ repoman commit -m "Set myself (binki) as maintainer."
[ERROR] !!! Please fix the following issues reported from cvs: (U,P,M,A,R,D are ok)
[ERROR] !!! Note: This is a pretend/no-modify pass...
[ERROR] |      o.E=+      |
|     o =+*       |
|      = *.o .    |
|     . =   = o   |
|      o S o + .  |
|           =     |
|          . .    |
|                 |
|                 |
M ChangeLog
M Manifest
M metadata.xml
ohnobinki@ohnopublishing ~/gentoo-x86/dev-libs/liblist $ cvs up
Host key fingerprint is 84:db:48:d1:39:45:a4:c8:f4:fd:6c:0d:fa:18:81:19
+[RSA 2048]-------+
|      o.E=+      |
|     o =+*       |
|      = *.o .    |
|     . =   = o   |
|      o S o + .  |
|           =     |
|          . .    |
|                 |
|                 |
+-----------------+

M ChangeLog
M Manifest
M metadata.xml
ohnobinki@ohnopublishing ~/gentoo-x86/dev-libs/liblist $ echo $?
0

[Comment 1 Nathan Phillip Brink (binki) (RETIRED) 2011-07-01 03:54:23 UTC]

Created attachment 278747 [details]
emerge--info.txt

[Comment 2 Michał Górny 2011-08-30 10:14:55 UTC]

Created attachment 285065 [details, diff]
Discard STDERR from cvs output

This shall fix it.

[Comment 3 Zac Medico 2011-08-30 16:27:23 UTC]

(In reply to comment #2)
> Created attachment 285065 [details, diff]
> Discard STDERR from cvs output
> 
> This shall fix it.

Thanks, this is in git now:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=41f12443efdab544ace9f2c90df516360ebf9df1

[Comment 4 Zac Medico 2011-09-19 04:15:36 UTC]

This is fixed in 2.1.10.12 and 2.2.0_alpha52.