On OS X, with gtk+ supporting quartz, pygtk-2.24.0 fails to compile due to Objective-C framework header included without specifying -xobjective-c. The first place of the error in the log looks like: In file included from /System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:8, from /System/Library/Frameworks/AppKit.framework/Headers/AppKit.h:10, from /Users/tetsushi/Gentoo/usr/include/gtk-2.0/gdk/gdkquartz.h:24, from ./gdk.override:41: /System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:189: error: stray '@' in program The problem is already discussed in https://bugzilla.gnome.org/show_bug.cgi?id=646743 The attachments will be a patch from the URL above and a modified ebuild.
Created attachment 275855 [details, diff] pygtk-2.24.0-use-objective-c-for-quartz.patch
Created attachment 275857 [details] ebuild
Could you report this problem to upstream?
(In reply to comment #3) > Could you report this problem to upstream? Please read my report carefully. > The problem is already discussed in > https://bugzilla.gnome.org/show_bug.cgi?id=646743 I think we can expect the issue WILL be fixed in upstream. But, currently we DO need patching.
(In reply to comment #4) > (In reply to comment #3) > > Could you report this problem to upstream? > > Please read my report carefully. > > > The problem is already discussed in > > https://bugzilla.gnome.org/show_bug.cgi?id=646743 I've reported patched and unpatched build log and working demo with the patch to the upstream bug. It now get fixed in upstream Git http://git.gnome.org/browse/pygtk/commit/?id=f655433394b10ccea585f54f38a9531304b4b084 http://git.gnome.org/browse/pygtk/commit/?id=bb95948271a2db1df1343b94451e0f5a90442bfd Prefix team, Could you apply the attached patch until next version come out? Though there are two commits in upstream Git, the latter patch was applied to fix the former patch's typo. The attached patch here already has the fix, so just applying the patch is enough.
@naota: pygtk is not in our tree, and python people forbid us to commit to their ebuilds.
(In reply to comment #6) > @naota: > pygtk is not in our tree, and python people forbid us to commit to their > ebuilds. ah, I was thinking it's in prefix tree... hm, would it be possible to import the package in prefix and fix it in the tree? # actually, it get fixed in my local overlay, so I'm not so hasting ...
(In reply to comment #7) > (In reply to comment #6) > > @naota: > > pygtk is not in our tree, and python people forbid us to commit to their > > ebuilds. > > ah, I was thinking it's in prefix tree... > hm, would it be possible to import the package in prefix and fix it in the > tree? no we should just hope that the python people are a bit more liberal these days. @python: would you please consider adding the upstream(ed) patches to resolve this issue, or allow us to add them?
Fixed with https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=45de86a213440aaf9e5cdee8c88e35d67d7778c1 commit 45de86a213440aaf9e5cdee8c88e35d67d7778c1 Author: Guilherme Amadio <amadio@gentoo.org> Date: Tue Mar 14 10:07:01 2017 -0300 dev-python/pygtk: Fix build on macOS, bugs 370079 and 400843
