Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 369387 - x11-libs/vte fails because of underlinking
Summary: x11-libs/vte fails because of underlinking
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: underlinking
  Show dependency tree
 
Reported: 2011-05-30 21:03 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2011-10-04 20:49 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (vte-0.28.0-r300:20110530-193701.log,24.06 KB, text/plain)
2011-05-30 21:03 UTC, Diego Elio Pettenò (RETIRED)
Details
new vte-0.28.0-fix-gdk-targets.patch (vte-0.28.0-fix-gdk-targets.patch,988 bytes, patch)
2011-09-27 05:12 UTC, Naohiro Aota
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2011-05-30 21:03:25 UTC
Created attachment 275225 [details]
Build log

Hello there!

You're getting this bug because the package in Summary failed to build in my tinderbox using the gold link editor from binutils. Before closing the bug as INVALID let me explain why this is still important!

The gold link editor does not support underlinking of shared objects, which is something I have described in my blog post:

http://blog.flameeyes.eu/2010/11/26/it-s-not-all-gold-that-shines-why-underlinking-is-a-bad-thing

Even the basic link editor (ld.bfd) has an option to support this but it is a heck to enable and get passed, so linking with gold is simply quicker.

Fixing underlinking provides optimized --as-needed builds (because the "softer" version no longer need to recover libraries that are underlinked), so it is a Good Thing To Do.

Thank you very much for the attention!
Comment 1 Pacho Ramos gentoo-dev 2011-06-17 19:08:46 UTC
This should also be reported to upstream -> bugzilla.gnome.org
Comment 2 Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-06-19 03:34:02 UTC
See https://bugzilla.gnome.org/show_bug.cgi?id=613525

vte upstream doesn't want to fix this bug because they think it's gtk's fault; gtk upstream disagrees and won't fix it either :/
Comment 3 Naohiro Aota gentoo-dev 2011-09-26 18:28:58 UTC
Seems this is fixed with this commit
http://git.gnome.org/browse/vte/commit/?id=be41faea3651c2a90012648490ebf346eac82d04

The actual problem now is this configure line

"checking for GDK target... "

This is from:

AC_MSG_CHECKING([for GDK target])
AC_MSG_RESULT([$GDK_TARGETS])

in configure.in. This "blank" mean GDK_TARGETS is mis-detected (it should be x11 usually on Linux). If there is x11 in GDK_TARGETS, it add link to x11 as the above commit do.

We are applying vte-2.28.0-fix-gdk-targets.patch and this patch is the root of this problem. You see this line in the build.log

"./configure: line 3084: --variable: command not found"

This patch try to use PKG_CONFIG before the configure set it. We should fix the patch to detect GDK_TARGET properly.
Comment 4 Naohiro Aota gentoo-dev 2011-09-27 05:12:21 UTC
Created attachment 287883 [details, diff]
new vte-0.28.0-fix-gdk-targets.patch

Replacing vte-0.28.0-fix-gdk-tragets.patch with this file solved the problem. Please review this new patch and commit it if there's no problem with it.
Comment 5 Pacho Ramos gentoo-dev 2011-09-27 11:57:55 UTC
Looks to work fine for me, but would prefer to wait a bit for other team members to confirm

(If in a week or so no action was taken, feel free to comment again here to push this up)
Comment 6 Pacho Ramos gentoo-dev 2011-10-04 20:49:53 UTC
Fixed, thanks a lot