Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 367859 - media-sound/quark fails because of underlinking
Summary: media-sound/quark fails because of underlinking
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: underlinking
  Show dependency tree
 
Reported: 2011-05-18 01:16 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2012-05-31 16:11 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (quark-3.21:20110517-202013.log,17.36 KB, text/plain)
2011-05-18 01:16 UTC, Diego Elio Pettenò (RETIRED)
Details
quark-3.21-build.patch (quark-3.21-build.patch,1.31 KB, patch)
2012-01-18 15:36 UTC, Michael Palimaka (kensington)
Details | Diff
quark-3.21.ebuild.patch (quark-3.21.ebuild.patch,1.36 KB, patch)
2012-01-18 15:48 UTC, Michael Palimaka (kensington)
Details | Diff
build log 2 (stdin.txt,7.84 KB, text/plain)
2012-05-28 17:09 UTC, Sławomir Nizio
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2011-05-18 01:16:13 UTC
Created attachment 273761 [details]
Build log

Hello there!

You're getting this bug because the package in Summary failed to build in my tinderbox using the gold link editor from binutils. Before closing the bug as INVALID let me explain why this is still important!

The gold link editor does not support underlinking of shared objects, which is something I have described in my blog post:

http://blog.flameeyes.eu/2010/11/26/it-s-not-all-gold-that-shines-why-underlinking-is-a-bad-thing

Even the basic link editor (ld.bfd) has an option to support this but it is a heck to enable and get passed, so linking with gold is simply quicker.

Fixing underlinking provides optimized --as-needed builds (because the "softer" version no longer need to recover libraries that are underlinked), so it is a Good Thing To Do.

Thank you very much for the attention!
Comment 1 Michael Palimaka (kensington) gentoo-dev 2012-01-18 15:36:31 UTC
Created attachment 299241 [details, diff]
quark-3.21-build.patch

Patch to fix underlinking, make debug behave better, and integrate sed from ebuild.
Comment 2 Michael Palimaka (kensington) gentoo-dev 2012-01-18 15:48:01 UTC
Created attachment 299247 [details, diff]
quark-3.21.ebuild.patch

- Correct ordering of variables
- Add missing deps
- Refix bug #226777 which got lost in the last commit
Comment 3 Sławomir Nizio 2012-05-28 17:09:16 UTC
Created attachment 313399 [details]
build log 2

This is probably going to hit more users because AFAIK GCC (4.6.2 or so) doesn't allow indirect linking now. Attaching another build log which probably shows the issue in a more clear way as a form of "me too."
Comment 4 Julian Ospald 2012-05-31 13:20:53 UTC
there is a version bump available, homepage is wrong too

I'll take care of that.
Comment 5 Julian Ospald 2012-05-31 16:11:01 UTC
*quark-3.24 (31 May 2012)

  31 May 2012; Julian Ospald <hasufell@gentoo.org> +quark-3.24.ebuild,
  +files/quark-3.24-build.patch, metadata.xml:
  version bump

  31 May 2012; Julian Ospald <hasufell@gentoo.org> quark-3.21.ebuild:
  fix underlinking wrt #367859, fix homepage