Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 367817 - net-firewall/iptables-1.4.10: initscript not completely openrc compatible
Summary: net-firewall/iptables-1.4.10: initscript not completely openrc compatible
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Peter Volkov (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 367793
  Show dependency tree
 
Reported: 2011-05-17 20:59 UTC by Robert Trace
Modified: 2011-06-16 12:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Remove svc_(start|stop) and make openrc compatible (iptables-init-openrc.patch,478 bytes, patch)
2011-05-17 21:01 UTC, Robert Trace
Details | Diff
iptables.initd.patch (iptables-init.patch,479 bytes, patch)
2011-05-18 01:19 UTC, Robert Trace
Details | Diff
iptables.initd.patch (iptables.initd.patch,478 bytes, patch)
2011-05-24 18:46 UTC, Robert Trace
Details | Diff
iptables.initd.patch (iptables.initd.patch,474 bytes, patch)
2011-05-24 18:56 UTC, Robert Trace
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Trace 2011-05-17 20:59:31 UTC
Initscript uses svc_(start|stop).  These functions don't appear to be supported
in openrc.


Reproducible: Always
Comment 1 Robert Trace 2011-05-17 21:01:11 UTC
Created attachment 273717 [details, diff]
Remove svc_(start|stop) and make openrc compatible
Comment 2 Robert Trace 2011-05-18 01:19:36 UTC
Created attachment 273773 [details, diff]
iptables.initd.patch

Updated patch taking in comments from bug 367815, comment 2.  Fix logic (it was wrong previously).
Comment 3 Peter Volkov (RETIRED) gentoo-dev 2011-05-24 09:14:19 UTC
Please check where did you get that init script from. Our init script looks differently...

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/net-firewall/iptables/files/iptables-1.3.2.init?revision=1.6&view=markup
Comment 4 Robert Trace 2011-05-24 18:43:22 UTC
(In reply to comment #3)
> Please check where did you get that init script from. Our init script looks
> differently...

Whoops.  My second patch was a delta on my first patch.  I'll fix it.  The bug is still valid (and is visible if you actually look at the line 103 of the file linked above).
Comment 5 Robert Trace 2011-05-24 18:46:50 UTC
Created attachment 274525 [details, diff]
iptables.initd.patch

Corrected version of patch.  v2 was delta'ed against v1 instead of the base version in CVS.
Comment 6 Robert Trace 2011-05-24 18:56:32 UTC
Created attachment 274529 [details, diff]
iptables.initd.patch

grr... I posted the old patch again.  (I need a better workflow.)

Let's try this one more time but with the correct contents.

Sorry about the bugspam.
Comment 7 Peter Volkov (RETIRED) gentoo-dev 2011-06-16 12:53:06 UTC
Thank you for this job Robert. Fixed in the tree.