Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 366109 - media-sound/alsa-utils should use systemd.eclass to install systemd units
Summary: media-sound/alsa-utils should use systemd.eclass to install systemd units
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo ALSA team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: systemd-consumers
  Show dependency tree
 
Reported: 2011-05-05 16:28 UTC by Michał Górny
Modified: 2011-05-05 17:19 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-05-05 16:28:36 UTC
Upstream does supply a set of systemd unit files in the distribution tarball and an ability to control installation of those files through the --with/--without-systemdsystemunitdir option. The ebuild is currently unaware of these options, making installation of systemd units pkgconfig file dependant and thus automagic.

The ebuild shall use systemd.eclass to handle installation of the systemd unit files in a clean and unified way.

The preferred way to handle that is to use autotools-utils eclass, and call `systemd_to_myeconfargs' before `autotools-utils_src_configure', as in:

	inherit autotools-utils systemd

	src_configure() {
		local myeconfargs=(
			$(use_enable foo)
			--with-bar
		)

		myeconfargs
		autotools-utils_src_configure
	}

If you're not interested in migrating to autotools-utils, there is also a legacy `systemd_with_unitdir' function, which could be used like that:

	inherit systemd

	src_configure() {
		econf \
			$(use_enable foo) \
			--with-bar \
			"$(systemd_with_unitdir)"
	}

Currently introduction of the eclass will cause the package to install systemd unit files unconditionally. If you don't like that concept, feel free to take a vote on the appropriate gentoo-dev ml topic. The eclass behaviour might change in future.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-05-05 16:32:27 UTC
Oops, in src_configure() s/^(\t+)(myeconfargs)/\1systemd_to_\2/.
Comment 2 Tony Vroon gentoo-dev 2011-05-05 17:07:32 UTC
On behalf of the sound herd, this proposed change is reviewed & acceptable for commit. Please proceed, making sure to revbump the ebuild. Thank you!
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-05-05 17:19:01 UTC
in gx86.