Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 365941 - sys-apps/dbus shall use systemd.eclass to install systemd units
Summary: sys-apps/dbus shall use systemd.eclass to install systemd units
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Doug Goldstein (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: systemd-consumers systemd-req
  Show dependency tree
 
Reported: 2011-05-04 11:22 UTC by Michał Górny
Modified: 2011-05-12 21:15 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch installing systemd units (0001-Install-systemd-units.patch,3.59 KB, patch)
2011-05-04 16:19 UTC, Michał Górny
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-05-04 11:22:42 UTC
As upstream supplies systemd unit files with sys-apps/dbus and dbus itself is an important dependency of systemd, its ebuild should use the systemd eclass to enable installing those units.

I am encouraging ebuild authors to migrate to autotools-utils and use systemd_to_econfargs which provides the eclass with more flexability, though with the current ebuild behaviour such a change looks complex. Thus, it shall at least replace `--without-systemdsystemunitdir' with "$(systemd_with_unitdir)" in the configure script arguments.
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2011-05-04 13:25:30 UTC
autotools-utils is a useless eclass (except for out of source builds) and should be only used as helper eclass for other eclasses (same as base eclass)
it adds extra complexity for stuff portage has always provided as is
so NAK from me

otherwise patches welcome for required changes for systemd
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-05-04 16:19:11 UTC
Created attachment 272099 [details, diff]
Patch installing systemd units

(In reply to comment #1)
> autotools-utils is a useless eclass (except for out of source builds) and
> should be only used as helper eclass for other eclasses (same as base eclass)
> it adds extra complexity for stuff portage has always provided as is
> so NAK from me

Do you have any other concept allowing eclass to provide a variable number of additional configure arguments possibly containing whitespace?(In reply to comment #1)

> otherwise patches welcome for required changes for systemd

Here you are.
Comment 3 Maciej Mrozowski gentoo-dev 2011-05-04 21:00:59 UTC
(In reply to comment #1)
> autotools-utils adds extra complexity for stuff portage has always provided
> as is, so NAK from me

Care to elaborate?
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2011-05-05 12:59:27 UTC
in portage