Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 364445 - virtual/mda-0 depends on package outside of portage tree
Summary: virtual/mda-0 depends on package outside of portage tree
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Net-Mail Packages
URL:
Whiteboard:
Keywords: QAcanfix
Depends on:
Blocks:
 
Reported: 2011-04-22 05:58 UTC by Ulrich Müller
Modified: 2011-04-24 05:21 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2011-04-22 05:58:17 UTC
RDEPEND contains mail-mta/citadel which is not in the portage tree (bug 62119 seems to indicate that it's in the sunrise overlay). Packages in the portage tree shouldn't depend on overlays.

Please remove that dependency. Sunrise should maintain its own copy of the virtual if they need packages from their overlay included.
Comment 1 Eray Aslan gentoo-dev 2011-04-22 06:26:43 UTC
+  22 Apr 2011; Eray Aslan <eras@gentoo.org> mda-0.ebuild:
+  drop citadel from RDEPEND - bug 364445
+
Comment 2 Ulrich Müller gentoo-dev 2011-04-22 06:28:14 UTC
Hey, that was a quick response. :)
Thanks.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-04-22 07:20:43 UTC
(In reply to comment #0)
> RDEPEND contains mail-mta/citadel which is not in the portage tree (bug 62119
> seems to indicate that it's in the sunrise overlay). Packages in the portage
> tree shouldn't depend on overlays.

Depending is one thing, one-of depending is another. I don't really see a reason why a virtual may not do something like that, considering that the preferred dependency (which would be pulled in by the PM if none of the packages is installed) is in gx86 anyway.

> Please remove that dependency. Sunrise should maintain its own copy of the
> virtual if they need packages from their overlay included.

Then any other overlay would contain its own copy, overriding the previous one and killing the packages in question.
Comment 4 Eray Aslan gentoo-dev 2011-04-22 07:36:10 UTC
(In reply to comment #3)
> I don't really see a
> reason why a virtual may not do something like that, considering that the
> preferred dependency (which would be pulled in by the PM if none of the
> packages is installed) is in gx86 anyway.

The reason I accepted the bug is we can't keep track of what the overlays do.  This one is rather straight forward but there are USE flags, version constraints etc to consider.  Better to keep the official tree consistent and let the overlays keep their tree consistent as well by managing their own versions of virtuals.

> Then any other overlay would contain its own copy, overriding the previous one
> and killing the packages in question.

Ehh?  Surely not if they manage it correctly.
Comment 5 Thomas Sachau gentoo-dev 2011-04-22 10:35:48 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > Then any other overlay would contain its own copy, overriding the previous one
> > and killing the packages in question.
> 
> Ehh?  Surely not if they manage it correctly.

And how would "they" (whoever that should be) manage it correctly?

Simple example: kde overlay and sunrise overlay, both with a mta, so both with a virtual/mta including main tree data and the mta from the overlay. Now user adds both overlays. One virtual/mta, e.g. from kde, will override the other, so if the user in this case installs the mta from sunrise, virtual/mta will still request another mta, since the kde one does not know about the mta from sunrise.

How do you want to resolve this properly without doing it in the main tree?
Comment 6 Eray Aslan gentoo-dev 2011-04-22 11:23:04 UTC
> And how would "they" (whoever that should be) manage it correctly?

Presumably, the email author will supply the revised virtual package.

> How do you want to resolve this properly without doing it in the main tree?

That way lies madness.  We cannot cater to all overlays in the main tree.  There are potentially too many of them.  In any case, I don't think *DEPENDing on a package outside of the main tree is a good idea.
Comment 7 Eray Aslan gentoo-dev 2011-04-22 11:27:09 UTC
(In reply to comment #6)
> Presumably, the email author will supply the revised virtual package.

Sigh.  s/email/package/
Comment 8 Thomas Sachau gentoo-dev 2011-04-22 23:05:39 UTC
(In reply to comment #6)
> > And how would "they" (whoever that should be) manage it correctly?
> 
> Presumably, the email author will supply the revised virtual package.
> 
> > How do you want to resolve this properly without doing it in the main tree?
> 
> That way lies madness.  We cannot cater to all overlays in the main tree. 
> There are potentially too many of them.  In any case, I don't think *DEPENDing
> on a package outside of the main tree is a good idea.

First question: Any real argument against additional packages from overlays in *DEPEND?

And second one still open: How do you want to resolve that example without doing it in the main tree?
Comment 9 Eray Aslan gentoo-dev 2011-04-24 05:21:25 UTC
http://archives.gentoo.org/gentoo-dev/msg_638e612675acbd39fc87b7d2e3ed50a7.xml

+  24 Apr 2011; Eray Aslan <eras@gentoo.org> mda-0.ebuild:
+  add mail-mta/citadel back again, hopefully, for the last time
+