Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 364009 - media-video/avidemux-2.5.4-r2 fails to build with gcc-4.6
Summary: media-video/avidemux-2.5.4-r2 fails to build with gcc-4.6
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Markos Chandras (RETIRED)
URL: http://avidemux.org/smf/index.php?top...
Whiteboard:
Keywords:
: 364029 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-04-18 10:46 UTC by Fabio Scaccabarozzi
Modified: 2011-04-29 14:11 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for QT4 "Open file" GUI (avidemux-2.5-gcc46-qt4_ui.patch,1.25 KB, text/plain)
2011-04-18 10:47 UTC, Fabio Scaccabarozzi
Details
Patch for x264 "Preset" GUI (avidemux-2.5-gcc46-x264_ui.patch,1.22 KB, patch)
2011-04-18 10:47 UTC, Fabio Scaccabarozzi
Details | Diff
Patch for xvid "Preset" GUI (avidemux-2.5-gcc46-xvid_ui.patch,1.22 KB, patch)
2011-04-18 10:48 UTC, Fabio Scaccabarozzi
Details | Diff
avidemux-2.5.4-r2.ebuild (avidemux-2.5.4-r2.ebuild,4.48 KB, text/plain)
2011-04-20 21:03 UTC, Billy DeVincentis
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fabio Scaccabarozzi 2011-04-18 10:46:29 UTC
I tried to compile media-video/avidemux-2.5.4-r2, but the compile phase always fails. I have been able to patch the problem successfully. GCC 4.6 is stricter than previous versions and avidemux code triggers some spots where some particular code semantics is not allowed by the standard.


Reproducible: Always

Steps to Reproduce:
1. emerge -1 gcc:4.6
2. use it as default compiler
3. emerge -1 avidemux
Actual Results:  
Avidemux fails to compile.

Expected Results:  
Avidemux should compile fine.

I'm on ~amd64 but I guess the compile errors should show up on any architecture when using GCC 4.6. The errors arise because GCC 4.6 is stricter than previous versions about code semantics. I tried with and without graphite flags (whole world was recompiled), and all of the available versions in portage. I have tried also the SVN ebuild from multimedia overlay but it still fails in the same spots.
The three attached patches resolve the problems and allow avidemux to compile fine. I've tested the avidemux GUI interface which is the affected part and it works ok.
It should not introduce errors with previous GCC versions since the patch is cosmetic only (I've been unable to test with GCC<4.6).
I guess this should also be filed upstream.
Thanks.
Comment 1 Fabio Scaccabarozzi 2011-04-18 10:47:02 UTC
Created attachment 270363 [details]
Patch for QT4 "Open file" GUI
Comment 2 Fabio Scaccabarozzi 2011-04-18 10:47:35 UTC
Created attachment 270365 [details, diff]
Patch for x264 "Preset" GUI
Comment 3 Fabio Scaccabarozzi 2011-04-18 10:48:03 UTC
Created attachment 270367 [details, diff]
Patch for xvid "Preset" GUI
Comment 4 Serkan Kaba (RETIRED) gentoo-dev 2011-04-18 11:58:46 UTC
Please post the patch upstream.
Comment 5 Fabio Scaccabarozzi 2011-04-18 12:43:50 UTC
(In reply to comment #4)
> Please post the patch upstream.

Done.
According to the thread on the forums the patches for qt4 and x264 interfaces have already been coded upstream.
I linked this bug and asked to pull the xvid one if it is still missing.

http://avidemux.org/admForum/viewtopic.php?pid=50437#p50437
Comment 6 Serkan Kaba (RETIRED) gentoo-dev 2011-04-18 15:10:28 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > Please post the patch upstream.
> 
> Done.
> According to the thread on the forums the patches for qt4 and x264 interfaces
> have already been coded upstream.
> I linked this bug and asked to pull the xvid one if it is still missing.
> 
> http://avidemux.org/admForum/viewtopic.php?pid=50437#p50437

Thanks, I modified the URL field accordingly. Let's wait until upstream acknowledges/commits your patch.
Comment 7 Billy DeVincentis 2011-04-20 21:03:17 UTC
Created attachment 270721 [details]
avidemux-2.5.4-r2.ebuild

Attached a working ebuild. Download all 3 patches and place in files directory. Indeed patches work.
Comment 8 Rafał Mużyło 2011-04-22 01:26:06 UTC
*** Bug 364029 has been marked as a duplicate of this bug. ***
Comment 9 Markos Chandras (RETIRED) gentoo-dev 2011-04-22 09:02:34 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > Please post the patch upstream.
> > 
> > Done.
> > According to the thread on the forums the patches for qt4 and x264 interfaces
> > have already been coded upstream.
> > I linked this bug and asked to pull the xvid one if it is still missing.
> > 
> > http://avidemux.org/admForum/viewtopic.php?pid=50437#p50437
> 
> Thanks, I modified the URL field accordingly. Let's wait until upstream
> acknowledges/commits your patch.

The upstream url seems broken or there is something wrong with their website. I will wait a little bit longer for their reply before I commit your patches
Comment 10 Markos Chandras (RETIRED) gentoo-dev 2011-04-28 15:27:38 UTC
Their forum changed URL ( http://avidemux.org/smf/index.php ). Can you post the new URL of your thread
Comment 11 Fabio Scaccabarozzi 2011-04-29 09:41:02 UTC
The thread was not mine, it was opened by a Fedora developer.
Avidemux.org have migrated their forums and it seems that the thread were this issue was being discussed has been lost in the transition.
However, by cloning the svn, I can confirm that the qt4_ui and x264_ui patches have been applied, while the xvid_ui one has not.
I re-opened the thread on the forums under the same name and asked to pull the Xvid patch. The URL field has been modified accordingly.
Comment 12 Fabio Scaccabarozzi 2011-04-29 09:44:17 UTC
s/thread were this/thread where this/
Comment 13 Markos Chandras (RETIRED) gentoo-dev 2011-04-29 14:11:15 UTC
  29 Apr 2011; Markos Chandras <hwoarang@gentoo.org> avidemux-2.5.4-r2.ebuild,
  +files/avidemux-2.5.4-openfileqt.patch,
  +files/avidemux-2.5.4-x264-build115.patch, +files/avidemux-2.5.4-x264.patch,
  +files/avidemux-2.5.4-xvid.patch:
  Add gcc-4.6 patches thanks to Fabio Scaccabarozzi <fsvm88@gmail.com>. Add
  patch for latest x264 thanks to zimous <zimous@matfyz.cz>. Bugs #364009 and
  #365153

Fixed. Thanks :)