Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 36069 - webapp-apache fixes for userpriv
Summary: webapp-apache fixes for userpriv
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Web Application Packages Maintainers
Depends on: 32636
Blocks: 36070
  Show dependency tree
Reported: 2003-12-18 08:41 UTC by Cory Visi (RETIRED)
Modified: 2004-03-25 16:12 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

webapp-apache.eclass (webapp-apache.eclass,3.56 KB, text/plain)
2003-12-18 08:41 UTC, Cory Visi (RETIRED)
Patch against webapp-apache.eclass v 1.19 2003/12/1 6 10:55:43 (webapp-apache.eclass.patch,3.07 KB, text/plain)
2004-01-03 15:33 UTC, Cory Visi (RETIRED)

Note You need to log in before you can comment on or make changes to this bug.
Description Cory Visi (RETIRED) gentoo-dev 2003-12-18 08:41:04 UTC
I read the bug history for webapp-apache and userpriv and I'm not sure exactly what you did to fix it for userprive, Stuart. htdig still did not emerge successfully for me.

In any case, I made a ton of changes to webapp-apache. I don't know why the apache.conf greps were commented out. I made them better and I tested them with userpriv and usersandbox. It works very nicely. The big change is moving the fperms and fowner to webapp-pkg_install(). In order for userpriv to work, they have to be in pkg_install. This is going to mean some more changed ebuilds I bet.

I made a theoretical assumption about this eclass as well. The big question is do you want webapp-apache to force a depend on the apache ebuild? A package like htdig does not really need a dependency on apache. It does, however, need webapp-apache.eclass to emerge (for pathnames). We can certainly make webapp-apache work without having apache installed (as I did). We can have it supply default Gentoo values for file locations if apache isn't installed, otherwise read the values from config files (this is what I've done). Is this how you want it to act? I think it makes the most sense this way, in any case.

My fixes are really fixes, clean-up, and enhancements. I recommend running a diff.

I don't expect you to accept this entire modification to the webapp-apache.eclass as is, but please consider the ideas I present and my implementation.

I'm also commiting a bug fix for htdig that allows it to work with userpriv enabled that will depend on this bug (it depends on my modifications to webapp-apache).
Comment 1 Cory Visi (RETIRED) gentoo-dev 2003-12-18 08:41:31 UTC
Created attachment 22406 [details]
Comment 2 Cory Visi (RETIRED) gentoo-dev 2003-12-18 08:43:21 UTC
This is related to Bug 32636.
Comment 3 Cory Visi (RETIRED) gentoo-dev 2003-12-18 09:02:06 UTC
By the way, the word is "deprecated", not "depreciated" (from your comments in the current ebuild) :).
Comment 4 Martin Holzer (RETIRED) gentoo-dev 2003-12-18 09:56:19 UTC
please submit diffs in future

*** This bug has been marked as a duplicate of 32636 ***
Comment 5 Cory Visi (RETIRED) gentoo-dev 2003-12-18 10:14:44 UTC
By marking this as a duplicate you closed the bug. Why? No one is going to look at it now and the eclass is definitely _not_ fixed.
Comment 6 Martin Holzer (RETIRED) gentoo-dev 2003-12-18 10:58:10 UTC
Comment 7 Stuart Herbert (RETIRED) gentoo-dev 2003-12-18 13:29:15 UTC
Hi Cory,

I haven't seen your proposed changes anywhere else other than in this bug today.  I didn't know they existed, and that's why I didn't consider them when I made the fixes I did to the webapp-apache eclass.  Where have you posted them before now?

htdig-3.1.6-r4 has just emerged successfully for me - with userprivs in the FEATURES in /etc/make.conf.  I cannot reproduce your problem.

Can you please post the following:

a) the captured output from running 'emerge htdig'
b) the $Header line from htdig-3.1.6-r4.ebuild

Thanks a lot,
Comment 8 Cory Visi (RETIRED) gentoo-dev 2003-12-18 21:55:57 UTC
Stuart, I didn't mean to alarm you. I just submitted my changes today. I was working on them in the last 3 days. I think some of them are good enhancements; no rush on reviewing them.

I am completely unable to reproduce my htdig problems, however, I did do an emerge rsync before reading this. Did you recently commit your webapp-apache.eclass updates? I completely debugged the problem when it occured. The fperms and fowners code in webapp-apache was running in the web-detect portion of the script, which gets called during src_unpack. This was causing a permissino denied error. I see now that you've created a webapp-apache-mkdirs function, which was not there when I assessed the problem originally, so I have to assume I just missed your updates! doh!

What do you think of my other changes?
Comment 9 Stuart Herbert (RETIRED) gentoo-dev 2003-12-19 06:24:04 UTC
It'd be a bit easier for me (because I'm at work and nowhere near a Linux box) if you could resubmit your webapp-apache changes as a diff against the latest webapp-apache.eclass file.

Comment 10 Cory Visi (RETIRED) gentoo-dev 2004-01-03 15:33:14 UTC
Created attachment 23111 [details]
Patch against webapp-apache.eclass v 1.19 2003/12/1 6 10:55:43

Sorry this took so long to submit
Comment 11 Stuart Herbert (RETIRED) gentoo-dev 2004-01-03 16:16:04 UTC
Okay thanks.  If you've not heard back from me within a week, please drop me a friendly reminder ;-)

Comment 12 Andrew Cooks (RETIRED) gentoo-dev 2004-02-07 03:23:41 UTC
Friendly reminder ;-)
Comment 13 Stuart Herbert (RETIRED) gentoo-dev 2004-02-07 10:11:28 UTC
Heh.  Thank you ;-)

Comment 14 Cory Visi (RETIRED) gentoo-dev 2004-03-25 16:12:15 UTC
I'm closing this bug because Stuart and I talked and decided it did not make sense to spend any time on this issue. Stuart's webapp-config utility and installation method will replace all of this confusion with an elegant solution.