Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 357661 - Unify "audio" local USE flag with "sound" global flag
Summary: Unify "audio" local USE flag with "sound" global flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Quality Assurance Team
URL:
Whiteboard:
Keywords: QAcanfix
Depends on:
Blocks:
 
Reported: 2011-03-06 15:29 UTC by Ulrich Müller
Modified: 2014-05-18 15:04 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2011-03-06 15:29:38 UTC
Following discussion in gentoo-dev:
<http://archives.gentoo.org/gentoo-dev/msg_e4e4974dcb53f9fc606cbe95f172f9c8.xml>

Both "audio" and "sounds" local USE flags should be renamed to "sound" (which is a global flag now). Affected packages:

games:
   games-action/abuse
   games-rpg/drascula
   games-strategy/heroes3
   media-libs/libsdl

pva:
   net-p2p/eiskaltdcpp

volkmar, voip:
   net-libs/opal
   net-libs/ptlib
Comment 1 Peter Volkov (RETIRED) gentoo-dev 2011-03-09 14:04:35 UTC
Ulrich, please, CC all maintainers next time :) net-p2p/eiskaltdcpp done.
Comment 2 Peter Volkov (RETIRED) gentoo-dev 2011-03-09 14:05:09 UTC
Oh, reopen, since only there are other packages left...
Comment 3 Tupone Alfredo gentoo-dev 2011-03-14 12:58:41 UTC
I did the change to 

   games-action/abuse
   games-rpg/drascula

To apply the change to media-libs/libsdl we should also take care of the ebuilds that depends on libsdl[audio]

media-tv/xbmc
media-sound/freewheeling
games-emulation/gngb
games-emulation/virtualjaguar
games-emulation/mednafen
games-emulation/openmsx
games-emulation/raine
games-emulation/hatari
games-emulation/lxdream
games-emulation/generator
games-board/biloba
games-board/gtkboard
games-kids/pytraffic
games-action/towbowl-tactics
games-action/teeworlds
games-action/extreme-tuxracer
games-action/maelstrom
games-action/supertuxkart
games-action/gltron
games-action/trackballs
games-action/violetland
games-action/d1x-rebirth
games-action/d2x
games-action/bzflag
games-rpg/adonthell
games-rpg/daimonin-client
games-roguelike/angband
games-engines/exult
games-engines/qtads
games-engines/stratagus
games-strategy/naev
games-strategy/boswars
games-strategy/freecnc
games-strategy/lgeneral
games-strategy/hedgewars
games-strategy/freeciv
games-puzzle/einstein
games-puzzle/zaz
games-puzzle/rezerwar
games-puzzle/gnurobbo
games-puzzle/neverball
games-puzzle/jag
games-puzzle/brainparty
games-puzzle/concentration
games-puzzle/amoebax
games-puzzle/wizznic
games-puzzle/bubble-chains
games-puzzle/cuyo
games-simulation/cannonsmash
games-simulation/simutrans
games-simulation/lincity-ng
games-simulation/openttd
games-simulation/gl117
games-sports/toycars
games-sports/race
games-arcade/missile
games-arcade/jumpnbump
games-arcade/slimevolley
games-arcade/tomatoes
games-arcade/rockdodger
games-arcade/lbreakout2
games-arcade/primateplunge
games-arcade/pengupop
games-arcade/sdlsasteroids
games-arcade/kajaani-kombat
games-arcade/amphetamine
games-arcade/yarsrevenge
games-fps/quake2-icculus
games-fps/rott

Are we sure that all that is really needed?
Comment 4 Ulrich Müller gentoo-dev 2011-04-07 09:44:46 UTC
(In reply to comment #3)
> To apply the change to media-libs/libsdl we should also take care of the
> ebuilds that depends on libsdl[audio]
> 
> [...]
> 
> Are we sure that all that is really needed?

Would be nice to have, and it's not really a problem to do these replacements with a script. (Maybe coordinate with infra, so that rsync mirrors will see an atomic change.)
Comment 5 Ulrich Müller gentoo-dev 2014-05-15 10:52:31 UTC
Since there's no action by maintainers here, I'm going to fix the following remaining packages and their reverse dependencies:

dastergon:
   app-misc/recoll

enlightenment:
   dev-libs/efl

games:
   games-strategy/heroes3
   media-libs/libsdl
   media-libs/libsdl2

maintainer-needed:
   net-libs/h323plus

neurogeek:
   net-libs/opal
   net-libs/ptlib
Comment 6 Ulrich Müller gentoo-dev 2014-05-15 12:06:40 UTC
> maintainer-needed:
>    net-libs/h323plus
> 
> neurogeek:
>    net-libs/opal
>    net-libs/ptlib

These are fixed.
Comment 7 Ulrich Müller gentoo-dev 2014-05-15 16:46:26 UTC
(In reply to Ulrich Müller from comment #5)
> games:
>    games-strategy/heroes3

This one has "sounds" and "videos" flags along with a "music" flag that install optional data. I'm leaving it like this, for the time being.

>    media-libs/libsdl
>    media-libs/libsdl2

Fixed.
Comment 8 Ulrich Müller gentoo-dev 2014-05-15 17:52:20 UTC
(In reply to Ulrich Müller from comment #5)
> Since there's no action by maintainers here,

Sorry, I should have worded this differently. "No action" relates only to the packages that were already listed in comment #0.

Please change the "audio" flag to "sound", or raise your objections why it shouldn't be done for your package.
Comment 9 Ulrich Müller gentoo-dev 2014-05-15 18:08:00 UTC
> enlightenment:
>    dev-libs/efl

Fixed, as discussed with tommy.
Comment 10 Günther Hutzl 2014-05-15 18:46:05 UTC
Hi!

I have encountered emerge problems now after the latest update. There are some packages left that still require the audio use flag. It would have been nice if all packages were fixed at once...

Here are my problematic packages:

media-tv/xbmc
media-video/ffmpeg
media-plugins/audacious-plugins

Please fix those as well.

Thank you!
Comment 11 Ulrich Müller gentoo-dev 2014-05-15 20:20:11 UTC
(In reply to Günther Hutzl from comment #10)
> It would have been nice if all packages were fixed at once...

They _have_ been fixed at once, but seems that not all of libsdl's 134 reverse dependencies made it into the same time slice for propagating from CVS to rsync. Re-sync and try again.
Comment 12 Julian Ospald 2014-05-16 12:39:33 UTC
this bug is 3 years old and you just went ahead and "fixed" things without contacting the active maintainers of e.g. libsdl2

you are aware that this simply breaks a LOT of overlays? Why has this been applied without any recent discussion?
Comment 13 Ulrich Müller gentoo-dev 2014-05-16 12:56:19 UTC
(In reply to Julian Ospald (hasufell) from comment #12)
> this bug is 3 years old and you just went ahead and "fixed" things without
> contacting the active maintainers of e.g. libsdl2
> 
> you are aware that this simply breaks a LOT of overlays? Why has this been
> applied without any recent discussion?

A link to the thread in -dev is in comment #0, and the conclusion was that audio should be renamed to sound. Why should it be discussed again, if there was consensus?

As for libsdl2, that package should have had IUSE="sound" (instead of "audio") from the very beginning.
Comment 14 Julian Ospald 2014-05-16 18:15:28 UTC
(In reply to Ulrich Müller from comment #13)
> (In reply to Julian Ospald (hasufell) from comment #12)
> > this bug is 3 years old and you just went ahead and "fixed" things without
> > contacting the active maintainers of e.g. libsdl2
> > 
> > you are aware that this simply breaks a LOT of overlays? Why has this been
> > applied without any recent discussion?
> 
> A link to the thread in -dev is in comment #0, and the conclusion was that
> audio should be renamed to sound. Why should it be discussed again, if there
> was consensus?
> 
> As for libsdl2, that package should have had IUSE="sound" (instead of
> "audio") from the very beginning.

I was talking about _recent_ discussion. This is not a trivial step and there was zero communication.

E.g. when I imported libsdl2 unslotted, I contacted all major game overlays beforehand.

This probably just broke most of the sunrise ebuilds as well. Did any1 tell them? I guess not.
Comment 15 Ulrich Müller gentoo-dev 2014-05-16 19:26:29 UTC
(In reply to Julian Ospald (hasufell) from comment #14)

So, what do you want us to do? Should media-libs/libsdl{,2} return to IUSE="audio", i.e. should the change be reverted? If that is the goal, then please restart discussion in the gentoo-dev mailing list.

Regarding "zero communication": This was discussed in gentoo-dev, and that the discussion was already some time ago doesn't invalidate it. There is this bug open since long, tagged with a QAcanfix keyword from the very beginning, and maintainers of libsdl and libsdl2 are in CC. In addition, I have announced the upcoming action again in comment #5. So this can hardly come as a surprise.

Also please note that for those packages whose maintainers were added to CC only recently, I have taken no action yet (except for efl, where tommy has given his o.k. on IRC).

That there is breakage for some packages in overlays is unfortunate, but responsibility for overlays is entirely with their owners. I'm not aware of any policy that would require consideration of overlays when committing to the main Portage tree.
Comment 16 Julian Ospald 2014-05-16 20:48:30 UTC
(In reply to Ulrich Müller from comment #15)
> (In reply to Julian Ospald (hasufell) from comment #14)
> 
> So, what do you want us to do?

Communicate more.
Comment 17 Ulrich Müller gentoo-dev 2014-05-17 07:35:04 UTC
> dastergon:
>    app-misc/recoll

Fixed, as discussed with dastergon.

All done, closing.
Comment 18 Andreas Klauer 2014-05-18 15:04:01 UTC
A version bump sure would've been nice for those changed ebuilds so the overlays don't blow up. :)