Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 356079 - net-fs/openafs fails to compile with app-crypt/heimdal-1.4.1 (krb5_524_conv_principal)
Summary: net-fs/openafs fails to compile with app-crypt/heimdal-1.4.1 (krb5_524_conv_p...
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Network Filesystems
URL: http://repo.or.cz/w/heimdal.git/commi...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-22 14:00 UTC by Moshe Kamensky
Modified: 2015-03-21 08:49 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for openafs 1.6.0 to compile against heimdal >= 1.4.1 (openafs-1.6.0-heimdal-1.4.1.patch,1.68 KB, patch)
2012-02-07 01:51 UTC, Andrew Hamilton
Details | Diff
ebuild which applies the previously attached patch (openafs-1.6.0.ebuild,4.38 KB, text/plain)
2012-02-07 01:55 UTC, Andrew Hamilton
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Moshe Kamensky 2011-02-22 14:00:49 UTC
The function krb5_524_conv_principal disappeared in heimdal-1.4.1, and as a result, openafs no longer builds. Still there in heimdal-1.4

Reproducible: Always

Steps to Reproduce:
1.install heimdal-1.4.1
2.try to run aklog or install openafs
3.
Comment 1 Eray Aslan gentoo-dev 2011-02-23 09:06:50 UTC
No more krb4 support in heimdal:
https://github.com/heimdal/heimdal/commit/fae3d127a2baa95e5533a0f5c6100005e8549f88

openafs checks for krb524_convert_creds_kdc in configure.ac:

         [AC_CHECK_FUNCS([krb524_convert_creds_kdc], 

and assumes having krb524_convert_creds_kdc() (which just returns "not supported" by the way) implies having krb5_524_conv_principal():

src/aklog/aklog.c:

#if !defined(HAVE_KRB5_524_CONVERT_CREDS) && defined(HAVE_KRB524_CONVERT_CREDS_KDC)
#define krb5_524_convert_creds krb524_convert_creds_kdc
#elif !defined(HAVE_KRB5_524_CONVERT_CREDS) && !defined(HAVE_KRB524_CONVERT_CREDS_KDC)
#define HAVE_NO_KRB5_524
#endif

which is no longer the case with heimdal.  Alternatives:

* remove krb524_convert_creds_kdc() from heimdal so that AC_CHECK_FUNCS fails for openafs.
* check for krb5_524_conv_principal() explicitly in openafs config script and adjust the logic in aklog.c accordingly.

I will ask heimdal upstream why krb524_convert_creds_kdc() is left behind.  It is not used anymore AFAIK.  But in the meantime, net-fs herd might want to patch the openafs configure script and/or aklog.c or block >app-crypt/heimdal-1.4

Re-assigning to net-fs.
Comment 2 Andrew Hamilton 2012-02-07 01:51:33 UTC
Created attachment 301103 [details, diff]
patch for openafs 1.6.0 to compile against heimdal >= 1.4.1

This patch modifies configure.ac to fix check for both krb5_524 functions and also modifies aklog.c to only enable krb5_524 if both the client and kdc functions are available.
Comment 3 Andrew Hamilton 2012-02-07 01:55:11 UTC
Created attachment 301105 [details]
ebuild which applies the previously attached patch

Testing ebuild which applies the patch for openafs 1.6.0 for heimdal >= 1.4.1
Comment 4 Andrew Hamilton 2012-02-07 02:00:50 UTC
I've attached a patch and ebuild which modify configure.ac to perform a more thorough check for krb5_524 as well as modifying aklog.c to only enable 524 support if both the client and kdc functions are detected.

I have tested this on amd64 with heimdal 1.5.1-r1 and these patches allow openafs-1.6.0 to compile and at least the client portions function as expected.
Comment 5 Andrew Hamilton 2012-02-15 05:20:48 UTC
I've forwarded the bug information and the patch I wrote upstream.  More information can be found on the openafs bug tracking system ticket #130575: http://rt.central.org/rt/Ticket/Display.html?id=130575
Comment 6 Tommie 2012-04-06 10:44:27 UTC
I just ran into the same problem on 1.6.1, and can confirm Andrew's patch solves it even for that version.

* OpenAFS 1.6.1
* Heimdal 1.5.1
* Linux 3.2.12
* AMD64
Comment 7 Andrew Savchenko gentoo-dev 2015-03-21 08:49:21 UTC
Superseeded by bug 398253.