Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 353066 - sys-devel/flex: EAPI3/Gentoo Prefix support
Summary: sys-devel/flex: EAPI3/Gentoo Prefix support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Prefix
URL: http://flex.git.sourceforge.net/git/g...
Whiteboard:
Keywords:
Depends on: 384221 440304 482178 499440 499456
Blocks: prefix-gx86
  Show dependency tree
 
Reported: 2011-01-28 15:57 UTC by Jeremy Olexa (darkside) (RETIRED)
Modified: 2016-05-23 19:37 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2011-01-28 15:57:53 UTC
Simple, s/2/3/ for EAPI, add KEYWORDS. Concerned about your opinion on if flex is too close to @system for EAPI3 or not. Since it is EAPI2 already, I guess it is fine?

This is all:

Index: flex-2.5.35_p10.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/sys-devel/flex/flex-2.5.35_p10.ebuild,v
retrieving revision 1.1
diff -u -r1.1 flex-2.5.35_p10.ebuild
--- flex-2.5.35_p10.ebuild      16 Nov 2010 20:32:45 -0000      1.1
+++ flex-2.5.35_p10.ebuild      28 Jan 2011 15:52:32 -0000
@@ -2,7 +2,7 @@
 # Distributed under the terms of the GNU General Public License v2
 # $Header: /var/cvsroot/gentoo-x86/sys-devel/flex/flex-2.5.35_p10.ebuild,v 1.1 2010/11/16 20:32:45 flameeyes Exp $

-EAPI=2
+EAPI=3

 inherit eutils flag-o-matic autotools

@@ -19,7 +19,7 @@

 LICENSE="FLEX"
 SLOT="0"
-KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~m68k ~mips ~ppc ~ppc64 ~s390 ~sh ~sparc ~x86 ~sparc-fbsd ~x86-fbsd"
+KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~m68k ~mips ~ppc ~ppc64 ~s390 ~sh ~sparc ~x86 ~ppc-aix ~sparc-fbsd ~x86-fbsd ~x64-freebsd ~x86-freebsd ~hppa-hpux ~ia64-hpux ~x86-interix ~amd64-linux ~ia64-linux ~x86-linux ~ppc-macos ~x64-macos ~x86-macos ~m68k-mint ~sparc-solaris ~sparc64-solaris ~x64-solaris ~x86-solaris"
 IUSE="nls static"

 DEPEND="nls? ( sys-devel/gettext )"
Comment 1 SpanKY gentoo-dev 2011-09-22 20:21:39 UTC
flex is no longer in the system set, so feel free to commit
Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2011-09-23 14:58:39 UTC
Since this bug was filed, we discovered that flex-2.5.35_p10 blocks bootstrapping and we masked it (bug 353609). I don't want to touch flex-2.5.35, so this bug is on hold until the next flex release or something else changes.
Comment 3 SpanKY gentoo-dev 2011-09-23 15:29:30 UTC
how about we:
 - change 2.5.35_p10 to EAPI=3
 - stabilize 2.5.35_p10
 - port 2.5.35 to EAPI=3 and add prefix KEYWORDS

that way any random fallout in 2.5.35 is irrelevant because all the non-prefix people have moved on to 2.5.35_p10.  and when the next release comes out, you just have to add new KEYWORDS.
Comment 4 Fabian Groffen gentoo-dev 2011-09-23 15:57:45 UTC
That would be convenient to us.
Comment 5 SpanKY gentoo-dev 2011-09-23 17:33:03 UTC
(1) is done:
http://sources.gentoo.org/sys-devel/flex/flex-2.5.35_p10.ebuild?r1=1.4&r2=1.5

(2) is in flight

(3) i'll leave to you :P
Comment 6 Christoph Junghans (RETIRED) gentoo-dev 2012-11-20 20:33:25 UTC
Recent versions of flex need a patch to support mint beside that there is no difference between gx86 and the prefix tree.
Comment 7 SpanKY gentoo-dev 2012-11-28 20:54:08 UTC
(In reply to comment #6)

i don't think that patch will fly.  you probably should add a configure check to see if -fPIC is supported and if so, then build libfl_pic.a via AM_CONDITIONAL.
Comment 8 Christoph Junghans (RETIRED) gentoo-dev 2012-12-06 15:58:19 UTC
A version of the patch, which uses libtool go accepted upstream, hence the next release should solve this problem.
Comment 9 Sergey Popov gentoo-dev 2013-04-09 15:51:51 UTC
sys-devel/flex-2.5.37 has prefix keywords, it seems that this is fixed some time ago

+  19 Feb 2013; Zac Medico <zmedico@gentoo.org> flex-2.5.37.ebuild:
+  Fix for prefix and add ~arm-linux + ~x86-linux keywords.
Comment 10 Christoph Junghans (RETIRED) gentoo-dev 2013-04-09 16:12:50 UTC
(In reply to comment #9)
> sys-devel/flex-2.5.37 has prefix keywords, it seems that this is fixed some
> time ago
It works on prefix systems, which support -fPIC. This bug can be closed with the next release of flex.
Comment 11 Michael Haubenwallner (RETIRED) gentoo-dev 2013-04-10 06:41:45 UTC
(In reply to comment #9)
> sys-devel/flex-2.5.37 has prefix keywords, it seems that this is fixed some
> time ago
> 
> +  19 Feb 2013; Zac Medico <zmedico@gentoo.org> flex-2.5.37.ebuild:
> +  Fix for prefix and add ~arm-linux + ~x86-linux keywords.

But it still is in prefix-overlay for some reason...

However, besides more keywords, the only diff now is the mint patch, and another one for rpl_realloc, reported upstream as
http://sourceforge.net/tracker/?func=detail&aid=3607335&group_id=97492&atid=618177
Comment 12 SpanKY gentoo-dev 2013-04-27 09:02:30 UTC
(In reply to comment #11)

well, i'm not inclined to pull in hacks to the main tree.  if the next flex version includes everything you need (by using libtool), then let's wait for that in the main tree.
Comment 13 Christoph Junghans (RETIRED) gentoo-dev 2014-03-18 17:13:36 UTC
Added flex-2.5.38-r1 to prefix overlay!

@haubi: I guess we need to re-add flex-2.5.37-rpl_alloc.patch?

@Alan: I dropped mint-patches as flex is now using libtool.
Comment 14 Christoph Junghans (RETIRED) gentoo-dev 2014-03-24 19:54:35 UTC
Re-added keywords in prefix-overlay.
Comment 15 Christoph Junghans (RETIRED) gentoo-dev 2014-03-28 15:38:04 UTC
in gx86:
+  28 Mar 2014; Christoph Junghans <ottxor@gentoo.org> flex-2.5.38-r1.ebuild:
+  added prefix keywords
+
Comment 16 Christoph Junghans (RETIRED) gentoo-dev 2014-04-03 14:41:03 UTC
The aix-ppc patch got merged upstream:
<http://sourceforge.net/p/flex/bugs/151/>

@base-system: can we add that?
Comment 17 SpanKY gentoo-dev 2016-05-23 18:18:07 UTC
(In reply to Christoph Junghans from comment #16)

that change is already in flex-2.6.1 which has been in the tree for a while.
why does flex-2.5 matter ?  i didn't think prefix ran stable keywords.
Comment 18 Christoph Junghans (RETIRED) gentoo-dev 2016-05-23 19:17:27 UTC
Yeah I guess with flex-2.6.1 in the tree, we can consider this bug obsolete.