Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 352839 - Please review EAPI3/Gentoo Prefix changes for =www-client/elinks-0.12_pre5-r1
Summary: Please review EAPI3/Gentoo Prefix changes for =www-client/elinks-0.12_pre5-r1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Michal Januszewski (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: prefix-gx86
  Show dependency tree
 
Reported: 2011-01-26 15:59 UTC by Jeremy Olexa (darkside) (RETIRED)
Modified: 2011-01-31 16:54 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2011-01-26 15:59:45 UTC
Hello, here is an inline diff of the changes that I am proposing for Gentoo Prefix support. Please review and let me know, I can commit if you like.

Index: elinks-0.12_pre5-r1.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/www-client/elinks/elinks-0.12_pre5-r1.ebuild,v
retrieving revision 1.7
diff -u -r1.7 elinks-0.12_pre5-r1.ebuild
--- elinks-0.12_pre5-r1.ebuild  6 Jan 2011 21:41:15 -0000       1.7
+++ elinks-0.12_pre5-r1.ebuild  26 Jan 2011 15:57:44 -0000
@@ -2,7 +2,7 @@
 # Distributed under the terms of the GNU General Public License v2
 # $Header: /var/cvsroot/gentoo-x86/www-client/elinks/elinks-0.12_pre5-r1.ebuild,v 1.7 2011/01/06 21:41:15 spock Exp $

-EAPI="2"
+EAPI="3"

 inherit eutils autotools flag-o-matic

@@ -14,7 +14,7 @@

 LICENSE="GPL-2"
 SLOT="0"
-KEYWORDS="~alpha ~amd64 ~hppa ~ia64 ~mips ~ppc ~ppc64 ~sparc ~x86 ~x86-fbsd"
+KEYWORDS="~alpha ~amd64 ~hppa ~ia64 ~mips ~ppc ~ppc64 ~sparc ~x86 ~x86-fbsd ~x86-freebsd ~amd64-linux ~x86-linux ~ppc-macos ~x86-macos ~sparc-solaris ~x64-solaris ~x86-solaris"
 IUSE="bittorrent bzip2 debug finger ftp gopher gpm guile idn ipv6 \
          javascript lua +mouse nls nntp perl ruby samba ssl unicode X zlib"
 RESTRICT="test"
@@ -71,13 +71,13 @@
        fi

        if use ssl ; then
-               myconf="${myconf} --with-openssl"
+               myconf="${myconf} --with-openssl=${EPREFIX}/usr"
        else
                myconf="${myconf} --without-openssl --without-gnutls"
        fi

        econf \
-               --sysconfdir=/etc/elinks \
+               --sysconfdir="${EPREFIX}"/etc/elinks \
                --enable-leds \
                --enable-88-colors \
                --enable-256-colors \
@@ -102,7 +102,7 @@
                $(use_enable finger) \
                $(use_enable samba smb) \
                $(use_enable mouse) \
-               ${myconf} || die
+               ${myconf}
 }

 src_install() {
@@ -121,7 +121,7 @@

        # Remove some conflicting files on OSX.  The files provided by OSX 10.4
        # are more or less the same.  -- Fabian Groffen (2005-06-30)
-       rm -f "${D}"/usr/share/locale/locale.alias "${D}"/usr/lib/charset.alias
+       rm -f "${ED}"/usr/share/locale/locale.alias "${ED}"/usr/lib/charset.alias
 }

 pkg_postinst() {
Comment 1 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2011-01-31 16:54:27 UTC
Changes were not that intrusive so I went ahead and committed it.

+  31 Jan 2011; Jeremy Olexa <darkside@gentoo.org>
+  elinks-0.12_pre5-r1.ebuild:
+  Port changes from Gentoo Prefix, use EPREFIX/ED, add KEYWORDS, convert to
+  EAPI3. bug 352839