352712 – Please review EAPI3/Gentoo Prefix changes for =www-client/lynx-2.8.8_pre5

Bug 352712 - Please review EAPI3/Gentoo Prefix changes for =www-client/lynx-2.8.8_pre5

Summary: Please review EAPI3/Gentoo Prefix changes for =www-client/lynx-2.8.8_pre5

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo/Alt
Classification:	Unclassified
Component:	Prefix Support (show other bugs)
Hardware:	All Linux

Importance:	High enhancement (vote)
Assignee:	Gentoo Prefix

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	prefix-gx86
	Show dependency tree

Reported:	2011-01-25 17:15 UTC by Jeremy Olexa (darkside) (RETIRED)
Modified:	2011-01-31 16:57 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jeremy Olexa (darkside) (RETIRED) archtester

2011-01-25 17:15:35 UTC

pretty straightforward, with one special patch for FreeMiNT. 

Index: lynx-2.8.8_pre5.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/www-client/lynx/lynx-2.8.8_pre5.ebuild,v
retrieving revision 1.2
diff -u -r1.2 lynx-2.8.8_pre5.ebuild
--- lynx-2.8.8_pre5.ebuild      21 Jan 2011 07:03:13 -0000      1.2
+++ lynx-2.8.8_pre5.ebuild      25 Jan 2011 17:11:25 -0000
@@ -2,7 +2,7 @@
 # Distributed under the terms of the GNU General Public License v2
 # $Header: /var/cvsroot/gentoo-x86/www-client/lynx/lynx-2.8.8_pre5.ebuild,v 1.2 2011/01/21 07:03:13 wormo Exp $

-EAPI=2
+EAPI=3

 inherit eutils versionator

@@ -32,7 +32,7 @@

 LICENSE="GPL-2"
 SLOT="0"
-KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~m68k ~mips ~ppc ~ppc64 ~s390 ~sh ~sparc ~x86 ~sparc-fbsd ~x86-fbsd"
+KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~m68k ~mips ~ppc ~ppc64 ~s390 ~sh ~sparc ~x86 ~ppc-aix ~sparc-fbsd ~x86-fbsd ~x64-freebsd ~x86-freebsd ~ia64-hpux ~x86-interix ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~x86-macos ~m68k-mint ~sparc-solaris ~sparc64-solaris ~x64-solaris ~x86-solaris"
 IUSE="bzip2 cjk gnutls idn ipv6 nls ssl unicode"

 RDEPEND="sys-libs/ncurses[unicode?]
@@ -68,6 +68,7 @@

        # fix configure for openssl compiled with kerberos (bug #267749)
        epatch "${FILESDIR}/lynx-2.8.7-configure-openssl.patch"
+       epatch "${FILESDIR}"/${PN}-2.8.6-mint.patch
 }

 src_configure() {
@@ -116,11 +117,11 @@
        make install DESTDIR="${D}" || die

        sed -i -e "s|^HELPFILE.*$|HELPFILE:file://localhost/usr/share/doc/${PF}/lynx_help/lynx_help_main.html|" \
-                       "${D}"/etc/lynx.cfg || die "lynx.cfg not found"
+                       "${ED}"/etc/lynx.cfg || die "lynx.cfg not found"
        if use unicode
        then
                sed -i -e '/^#CHARACTER_SET:/ c\CHARACTER_SET:utf-8' \
-                               "${D}"/etc/lynx.cfg || die "lynx.cfg not found"
+                               "${ED}"/etc/lynx.cfg || die "lynx.cfg not found"
        fi
        dodoc CHANGES COPYHEADER PROBLEMS README
        docinto docs

May I commit this?

Comment 1 Jeremy Olexa (darkside) (RETIRED) archtester

2011-01-31 16:57:13 UTC

Changes were not that intrusive so I went ahead and committed it.

+  31 Jan 2011; Jeremy Olexa <darkside@gentoo.org>
+  +files/lynx-2.8.6-mint.patch, lynx-2.8.8_pre5.ebuild:
+  Port changes from Gentoo Prefix, use ED, add KEYWORDS, convert to EAPI3,
+  add FreeMiNT patch. bug 352712