Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 349855 - bump request: media-libs/gst-plugins-base to 0.10.31
Summary: bump request: media-libs/gst-plugins-base to 0.10.31
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: GStreamer package maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-27 13:26 UTC by Martin Rapavý
Modified: 2011-01-12 19:19 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
updated ebuild (gst-plugins-base-0.10.31.ebuild,1.44 KB, text/plain)
2010-12-31 08:34 UTC, Guillaume ZITTA
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Rapavý 2010-12-27 13:26:54 UTC
Hello, comrades,
could you please bump the version of "media-libs/gst-plugins-base" to 0.10.31, to keep it in line with "media-libs/gstreamer"?

You know, the issue is that these 2 packages are so closely tied together that a version mismatch may break them, as it happens in this case.

There have been some changes in the API (http://www.gstreamer.net/releases/gst-plugins-base/0.10.31.html), e. g., the function gst_x_overlay_set_xwindow_id(,) has been flagged (and enclosed in preprocessor directives) as deprecated and replaced by the function gst_x_overlay_set_window_handle(,), introduced here:
http://cgit.freedesktop.org/gstreamer/gst-plugins-base/diff/gst-libs/gst/interfaces/xoverlay.c?id=6dc02137fb8e952c79479f0c1154831c1b761410

Some developers of some software packages have already noticed this and have implemented the change, and check for the version of the installed GStreamer to choose the most appropriate code path.
E. g., as in Webkit, as it can be seen here:
http://trac.webkit.org/changeset/67621/trunk/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp#file0
But because the version 0.10.30 of gst-plugins-base does not have a clue about the newly introduced function yet, source code compilation along the newly introduced code path will then fail, as it happens with the above-mentioned (still unstable, master branch of) Webkit.

Or are there any reasons not to bump the version?
(And then the versions of the numerous associated and split-off packages – why are they so almost unmanageably fragmented, after all?)
BTW, they you may drop all the patches in the "$FILESDIR" subdirectory from this version, they are no longer needed, as they have already been applied upstream.

And perhaps the "media-libs/gstreamer" ebuild should be revised, too, in order to block a lower version of "media-libs/gst-plugins-base", or something like that... (What do you think about this?)

Sorry about not reporting the issue earlier, but I have been away during the holidays.

Cheers,
Martin
Comment 1 Guillaume ZITTA 2010-12-31 08:34:55 UTC
Created attachment 258489 [details]
updated ebuild

same as 0.10.30, but without patches
Comment 2 Mart Raudsepp gentoo-dev 2011-01-02 18:50:40 UTC
So those upstream should check for the correct things version, not the wrong thing.

Something like this:

#ifdef GST_CHECK_PLUGINS_BASE_VERSION /* New since -base-0.10.31 */
  gst_x_overlay_set_window_handle(GST_X_OVERLAY(sink), m_videoWindow->videoWindowId()); 
#else
  gst_x_overlay_set_xwindow_id(GST_X_OVERLAY(sink), m_videoWindow->videoWindowId()); 
#endif
Comment 3 Arun Raghavan (RETIRED) gentoo-dev 2011-01-12 19:19:39 UTC
0.10.31 is now in tree.