Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 349649 - app-emulation/vmware-modules-1.0.0.25-r2 doesn't compile with kernel >=2.6.37
Summary: app-emulation/vmware-modules-1.0.0.25-r2 doesn't compile with kernel >=2.6.37
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal with 1 vote (vote)
Assignee: Gentoo VMWare Bug Squashers [disabled]
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-24 21:37 UTC by Alex Buell
Modified: 2011-03-18 15:17 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for 2.6.37 (vmware-modules-1.0.0.25-r2-defineSemaphore.patch,3.67 KB, patch)
2011-01-11 22:06 UTC, Mateusz Dziadko
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Buell 2010-12-24 21:37:52 UTC
Cannot compile app-emulation/vmware-modules-1.0.0.25-r1 with gentoo-sources-2.6.36-r5.

Fix is to upgrade to app-emulation/vmware-modules-1.0.0.25-r2. Please stabilise this revision asap.
Comment 1 Georg Hennig 2011-01-09 16:17:05 UTC
Does not compile for gentoo-sources-2.6.37 either. For further information how to avoid the error ("error: implicit declaration of function ‘init_MUTEX’"), please check
http://communities.vmware.com/message/1675554?tstart=0
Comment 2 Alex Buell 2011-01-09 16:20:38 UTC
(In reply to comment #1)
> Does not compile for gentoo-sources-2.6.37 either. For further information how
> to avoid the error ("error: implicit declaration of function
> ‘init_MUTEX’"), please check
> http://communities.vmware.com/message/1675554?tstart=0

Is this with app-emulation/vmware-modules-1.0.0.25-r1?
Comment 3 Georg Hennig 2011-01-10 20:25:40 UTC
> Is this with app-emulation/vmware-modules-1.0.0.25-r1?
> 

Yes, emerging fails with the same error message.
Comment 4 Alex Buell 2011-01-10 22:08:47 UTC
(In reply to comment #3)
> > Is this with app-emulation/vmware-modules-1.0.0.25-r1?
> > 
> 
> Yes, emerging fails with the same error message.

OK I'm hoping they'll stabilise app-emulation/vmware-modules-1.0.0.25-r2 soon and that will hopefully sort it for 2.6.36 and 2.6.37. I will be testing 2.6.37 with -r2 within the next few days. 

In the meantime, -r2 definitely does work with 2.6.36. 
Comment 5 Mateusz Dziadko 2011-01-11 22:06:00 UTC
Created attachment 259581 [details, diff]
patch for 2.6.37

I wrote a simple patch for 2.6.37-gentoo .

I had to reconfigure vmware-networking. (emerge --config vmware-workstation)

(for me working :) )
Comment 6 Alex Buell 2011-01-11 22:38:53 UTC
Thanks for that, you just beat me  to it! I can confirm that vmware-modules-1.0.0.25-r2 needs the patch to build under 2.6.37!
Comment 7 Willard Dawson 2011-01-13 13:24:23 UTC
(In reply to comment #6)
> Thanks for that, you just beat me  to it! I can confirm that
> vmware-modules-1.0.0.25-r2 needs the patch to build under 2.6.37!
> 

Likewise, I confirm the patch works for me on 2.6.37.

Thanks!
Comment 8 Vadim Kuznetsov (RETIRED) gentoo-dev 2011-01-13 21:06:46 UTC
thank y'all. patch is in the portage. I'll create a stabilization bug along with workstation 6.5.5 in a short while.
Comment 9 Evan Teran 2011-01-14 04:45:59 UTC
Unfortunately vmware-modules-1.0.0.25-r3 does not compile on my machine:

2.6.37-gentoo-sources, amd64
Comment 10 Evan Teran 2011-01-14 04:54:10 UTC
AHA, the error involves missing "unlock_kernel" and "lock_kernel" symbols. Seems that I need to recompile with BKL support :-P.

Perhaps the ebuild should check for this and give a reasonable message?

(In reply to comment #9)
> Unfortunately vmware-modules-1.0.0.25-r3 does not compile on my machine:
> 
> 2.6.37-gentoo-sources, amd64
> 

Comment 11 Sven Müller 2011-02-10 20:24:53 UTC
Hmm, is there a reason to respect BKL? Praised as one of the biggest improvements of 2.6.37 it shouldn't be necessary to activate BKL.
Comment 12 Vadim Kuznetsov (RETIRED) gentoo-dev 2011-02-10 20:38:56 UTC
(In reply to comment #10)
> AHA, the error involves missing "unlock_kernel" and "lock_kernel" symbols.
> Seems that I need to recompile with BKL support :-P.

You need to enable CONFIG_LOCK_KERNEL  (not CONFIG_BLK)
https://bugs.gentoo.org/show_bug.cgi?id=350739#c8


Comment 13 Alex Buell 2011-02-18 11:38:27 UTC
Seems to work just fine now that vmware-modules has gone stable. 
Comment 14 Guy 2011-03-11 02:00:33 UTC
(In reply to comment #12)
> (In reply to comment #10)
> > AHA, the error involves missing "unlock_kernel" and "lock_kernel" symbols.
> > Seems that I need to recompile with BKL support :-P.
> 
> You need to enable CONFIG_LOCK_KERNEL  (not CONFIG_BLK)
> https://bugs.gentoo.org/show_bug.cgi?id=350739#c8

I know I'm going to sound stupid, but I can't seem to find where to set CONFIG_LOCK_KERNEL. I can't see it under:

"General setup"

nor under:

"Processor type and features"

I probably turned off something else required for it to display but I haven't a clue as to what.

Can someone please give me some guidance?

Thanks!
Comment 15 Guy 2011-03-11 02:01:22 UTC
Oops! I forgot to note I'm using vanilla-sources-2.6.37.2
Comment 16 Guy 2011-03-11 05:15:02 UTC
The statement in comment #10 is correct.

The statement in comment #12 is incorrect.

For kernel series 2.6.37+, CONFIG_LOCK_KERNEL can only be turned back on by setting the new option:

Kernel hacking ==> Big Kernel Lock to [*].

This will set both
CONFIG_BKL=y
CONFIG_LOCK_KERNEL=y

This is required apparently because the vmmon.ko module still requires the BKL symbols to build.

The vmware-modules-1.0.0.25 ebuild should be modified to check for CONFIG_LOCK_KERNEL=y and complain with message pointing to BKL as above.
Comment 17 pavel 2011-03-18 11:24:51 UTC
*** This bug has been confirmed by popular vote. ***
Comment 18 Vadim Kuznetsov (RETIRED) gentoo-dev 2011-03-18 14:58:17 UTC
-r4 with BKL check is in portage. Thanks.
Comment 19 Alex Buell 2011-03-18 15:17:13 UTC
Although it's quite commendable that this has been fixed for newer kernels, I really think it is time that Vmware fixed it so that it can work with kernels that has got rid of the BKL completely. I will be running kernels without BKL in the near future.