Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 349558 - dev-libs/popt doesn't respect LIBDIR when installing .pc file
Summary: dev-libs/popt doesn't respect LIBDIR when installing .pc file
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard: patch
Keywords:
Depends on:
Blocks: 380025
  Show dependency tree
 
Reported: 2010-12-24 03:37 UTC by Matt Turner
Modified: 2011-08-31 19:02 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to fix hard-coded 'lib/pkgconfig' (fix-popt-pkgconfig-libdir.patch,992 bytes, patch)
2010-12-24 03:47 UTC, Matt Turner
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Turner gentoo-dev 2010-12-24 03:37:44 UTC
On MIPS N32 ABI, LIBDIR is lib32. I noticed that although popt's .so's were installed to /usr/lib32, its pkgconfig .pc file was installed to /usr/lib/pkgconfig.

To reproduce:

mkdir -p popt-test/install
cd popt-test
tar -xvzf /usr/portage/distfiles/popt-1.16.tar.gz
cd popt-1.16
./configure --prefix=`pwd`/../install --libdir=`pwd`/../install/usr/lib32/
make
make install

Now, see that in ../install/usr/lib32 the .so's have been installed but the .pc file is in ../install/lib/pkgconfig/.

Strangely enough, the .pc file is correct with information like
libdir=/home/mattst88/popt-test/popt-1.16/../install/usr/lib32
Comment 1 Matt Turner gentoo-dev 2010-12-24 03:47:08 UTC
Created attachment 257910 [details, diff]
patch to fix hard-coded 'lib/pkgconfig'

Tested working, according to previously stated test.
Comment 2 SpanKY gentoo-dev 2010-12-24 05:17:57 UTC
just patch the Makefile.in (to avoid timestamp issues).  or run sed on it.  either way, change looks fine if you wish to commit.
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2010-12-24 05:41:46 UTC
This change should be necessary only for the 'install' step? Then I'd use (to avoid messing with Makefile.* for timestamp/autotools:

emake DESTDIR="${D}" pkgconfigdir="/usr/$(get_libdir)/pkgconfig" install || die #349558

and mail your patch to upstream :)
Comment 4 Matt Turner gentoo-dev 2010-12-24 06:43:58 UTC
Sent the patch upstream.

I like Samuli's fix for now. Should I revbump to 1.16-r1 and drop back to ~arch?
Comment 5 SpanKY gentoo-dev 2010-12-24 15:55:02 UTC
trouble with the install step is that when the prefix guys want to screw with things, we'll probably have to tweak that further.  which is why i like the makefile/configure logic.  and because what we send upstream is what we actually use in the ebuild.
Comment 6 Matt Turner gentoo-dev 2010-12-24 22:42:36 UTC
Committed with vapier's suggestion to just modify Makefile.in.

Patch sent upstream: http://marc.info/?t=129317116500001&r=1&w=2

Unclear whether the patch has been committed upstream.