Thanks. :)
Created attachment 255597 [details, diff] Minimal changes required to bump ebuild Not a single patch folded in by upstream ... boo, hiss! Incidentally, I hope some of the changes I've proposed elsewhere can make it in. I've also one more bug to file which concerns automagical dependencies and then I'm done.
Here's my version of 1.6.2.14: http://confucius.dh.bytemark.co.uk/~kerin.millar/ebuilds/net-misc/asterisk/ It includes patches from bug 265567 and bug 346959. No corrections for the QA issues alluded to above though ... coming soon.
Minor carp: pkg_postinst uses "echo". It should be changed to "elog" because the blank lines are supposed to go to whichever PORTAGE_ELOG_SYSTEM targets are in effect, just like the other messages. As it stands, the lines just get squashed up. I'll add this to my version of the ebuild along with a few other tweaks very soon.
Note also that "echo" is a default PORTAGE_ELOG_SYSTEM target; there's no need to emulate it :p
More QA stuff: USE="debug" doesn't do anything but is defined in IUSE - my 1.6.2.14 ebuild has an implementation though. USE="static" doesn't do anything but is defined in IUSE.
+*asterisk-1.6.2.14 (02 Dec 2010) + + 02 Dec 2010; <chainsaw@gentoo.org> +files/1.6.2/asterisk.initd3, + -files/1.6.2/asterisk.logrotate, -files/1.6.2/asterisk.logrotate2, + -asterisk-1.6.2.13.ebuild, -asterisk-1.6.2.13-r1.ebuild, + +asterisk-1.6.2.14.ebuild: + Consolidate patchset in a tarball on the mirrors, closes bug #344015 by + Marcin Baczyński. Drop logrotate USE-flag, always install snippet, closes + bug #344181 by Jeroen Roovers. Updated init script to fix restart bug by Jaco + Kroon, closes bug #345307. Version bump closes bug #346737 by Jesse Adelman, + with an honourable mention for Kerin Millar for pointing out some QA matters + which are now fixed. Thank you Jesse, this is now in the Portage tree. I was on holiday while you submitted this bug, hence the delay. Kerin, thank you for pointing out the QA matters, they are now addressed. I quite a few other bug reports to address, so I did not use your diff. If there is anything left in 1.6.2.14 please file me a new report.
