Bug 346615 – flag-o-matic.eclass add -fgnu89-inline to ALLOWED_FLAGS

• Status: RESOLVED WONTFIX
• Product: Gentoo Linux

[Description Kacper Kowalik (Xarthisius) (RETIRED) 2010-11-24 08:37:23 UTC]

Multiple packages fail without it on Prefix (gcc in particular)

[Comment 1 Kacper Kowalik (Xarthisius) (RETIRED) 2010-11-24 08:37:54 UTC]

Created attachment 255285 [details, diff]
add -fgnu89-inline to ALLOWED_FLAGS

[Comment 2 SpanKY 2010-11-24 08:53:43 UTC]

err, what ?  -fgnu89-inline isnt a flag that should be managed by users and blindly thrown into make.conf' CFLAGS.  this is something that packages themselves should be managing.

[Comment 3 Kacper Kowalik (Xarthisius) (RETIRED) 2010-11-24 10:31:28 UTC]

(In reply to comment #2)
> err, what ?  -fgnu89-inline isnt a flag that should be managed by users and
> blindly thrown into make.conf' CFLAGS.  this is something that packages
> themselves should be managing.
OK that was "lazy" approach. 
Alternative: Maybe allow that in toolchain.eclass:gcc_do_filter_flags. Something like use custom-cflags || strip-flags and big warning "don't come whining without patches" ?

[Comment 4 SpanKY 2010-11-24 21:33:10 UTC]

yeah, i dont think that's worth the hassle.  especially considering the use case you're bringing to justify it.