Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 346553 - x11-terms/rxvt-unicode: force hints patch
Summary: x11-terms/rxvt-unicode: force hints patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High enhancement with 1 vote (vote)
Assignee: Jeroen Roovers (RETIRED)
URL: http://lists.schmorp.de/pipermail/rxv...
Whiteboard:
Keywords:
: 348382 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-11-23 19:06 UTC by Lasse Brun
Modified: 2010-12-22 19:12 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Urxvt hints patch (hints.patch,487 bytes, patch)
2010-11-23 19:08 UTC, Lasse Brun
Details | Diff
ebuild patch that disables smart-resize (disable-smart-resize.patch,249 bytes, patch)
2010-11-24 08:15 UTC, Alex Alexander (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lasse Brun 2010-11-23 19:06:50 UTC
I would like to see the rxvt hints patch from the Awesome wiki added to rxvt-unicode ebuild. 

Quote from the wiki
"When using urxvt (rxvt-unicode) without hints you can get artifacts on the buttom of the screen."

There is a screenshot on the wiki that will display the problem.

I have tested the patch with rxvt-unicode:9.09 and confirmed that the problem is still there and the patch is working.

URL to the patch and some more info ->
http://awesome.naquadah.org/wiki/Urxvt_Hints
Comment 1 Lasse Brun 2010-11-23 19:08:25 UTC
Created attachment 255207 [details, diff]
Urxvt hints patch
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2010-11-23 19:26:56 UTC
Please don't CC maintainers when you cannot assign bugs.
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2010-11-23 23:54:56 UTC
Don't remove maintainers either. :)
Comment 4 Alex Alexander (RETIRED) gentoo-dev 2010-11-24 08:08:46 UTC
heh :)

Jeroen, we could add a force-hints USE flag for it, what do you think?
Comment 5 Alex Alexander (RETIRED) gentoo-dev 2010-11-24 08:15:28 UTC
Created attachment 255283 [details, diff]
ebuild patch that disables smart-resize

hmm, there's a configure option called "smart-resize".

Lasse, could you try rebuilding rxvt-unicode without the patch, with this option disabled? If it works, we can add a USE flag for this instead of an unsupported patch.
Comment 6 Lasse Brun 2010-11-24 20:17:26 UTC
(In reply to comment #5)
> Created an attachment (id=255283) [details]
> ebuild patch that disables smart-resize
> 
> hmm, there's a configure option called "smart-resize".
> 
> Lasse, could you try rebuilding rxvt-unicode without the patch, with this
> option disabled? If it works, we can add a USE flag for this instead of an
> unsupported patch.
> 

Apparently smart resize is by default off with --enable-everything. I did however test with both --enable and --disable with no change to my issue.

Quote from http://pod.tst.eu/http://cvs.schmorp.de/rxvt-unicode/doc/rxvt.7.pod#Character_widths_are_not_correct

"--enable-smart-resize (default: off)
Add smart growth/shrink behaviour when resizing. This should keep the window corner which is closest to a corner of the screen in a fixed position."
Comment 7 Marc Arens 2010-12-14 15:24:16 UTC
*** Bug 348382 has been marked as a duplicate of this bug. ***
Comment 8 Jeroen Roovers (RETIRED) gentoo-dev 2010-12-14 19:26:56 UTC
I'm waiting for upstream to actually respond to the thread in the URL, but it has released two new versions without a hint (haha) of a patch. Could somebody give that thread a poke, please, seeing as there is interest in this patch, and my being reluctant to deviate to far from upstream's course.
Comment 9 Lasse Brun 2010-12-16 11:50:37 UTC
(In reply to comment #8)
> I'm waiting for upstream to actually respond to the thread in the URL, but it
> has released two new versions without a hint (haha) of a patch. Could somebody
> give that thread a poke, please, seeing as there is interest in this patch, and
> my being reluctant to deviate to far from upstream's course.
> 

I don't think upstream will apply the patch as the code change, even if it solves the problem, is not any good.

But i don't see why it should be a problem to add it as an optional patch with a use flag, several other ebuilds got patches that isn't applied or supported by upstream.
Comment 10 Alex Alexander (RETIRED) gentoo-dev 2010-12-22 19:12:01 UTC
Patch added, enabled by the 'force-hints' USE flag.

Thanks for reporting :)