media-video/mplayer-1.0_rc4_p20100612 QA: other │ │QA Notice: Package has poor programming practices which may compile fine but exhibit random runtime failures. │ │stream/stream.c:490: warning: implicit declaration of function 'usec_sleep' Unreported by QA but from the build log In file included from imgconvert.c:41: x86/mmx.h:24:2: warning: #warning Everything in this header is deprecated, use plain __asm__()! New code using this header will be rejected. stream/tv.h:114: warning: function declaration isn't a prototype stream/tv.h:115: warning: function declaration isn't a prototype stream/tv.h:116: warning: function declaration isn't a prototype stream/tv.h:117: warning: function declaration isn't a prototype stream/tv.h:118: warning: function declaration isn't a prototype stream/tv.h:119: warning: function declaration isn't a prototype stream/tv.h:120: warning: function declaration isn't a prototype stream/tv.h:121: warning: function declaration isn't a prototype command.c: In function 'mp_property_metadata': command.c:554: warning: assignment discards qualifiers from pointer target type command.c: In function 'mp_property_teletext_common': command.c:1895: warning: cast from pointer to integer of different size command.c: In function 'mp_property_teletext_mode': command.c:1943: warning: cast from pointer to integer of different size In file included from h264_cabac.c:40: x86/h264_i386.h: In function 'decode_significance_x86': x86/h264_i386.h:41: warning: cast from pointer to integer of different size x86/h264_i386.h:42: warning: cast from pointer to integer of different size x86/h264_i386.h: In function 'decode_significance_8x8_x86': x86/h264_i386.h:94: warning: cast from pointer to integer of different size I am not programmer enough to parse this stuff and declare yeah or nay it would overflow something So I'll just attach the build log it is only a bit of the actual output of course Reproducible: Always
Created attachment 253141 [details] build log
Created attachment 256612 [details] build log correct size should be 200+ kb Added missing #include <time.h> to streams/streams.c no more error Adding build log and patch against rc4_p20101114
Created attachment 256614 [details, diff] patch to add missing includes patch is against rc4_p20101114
From reply on mailing list "No, it's nonsense. There is no usec_sleep in time.h and the missing osdep/timer.h include was added 15 days after that bug report. Which is why there is "no more error" with p20101114" Will try to find a cvs tree to confirm this before closing,
git sources contain fix
