Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 343331 - sci-mathematics/maxima automake called by maintainer-mode
Summary: sci-mathematics/maxima automake called by maintainer-mode
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: Gentoo Science Mathematics related packages
URL: http://blog.flameeyes.eu/2008/06/13/m...
Whiteboard:
Keywords:
Depends on:
Blocks: bad-autotools
  Show dependency tree
 
Reported: 2010-10-30 09:18 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2011-02-17 17:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (maxima-5.22.1:20101030-031010.log,1.00 MB, text/plain)
2010-10-30 09:19 UTC, Diego Elio Pettenò (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-10-30 09:18:43 UTC
Hello,

You're receiving this canned (template-based) bug report because I found a problem with a package during my tinderbox run.

The package in question is running automake (and most likely other autotools) during compile phase by maintainer-mode. You can see in my blog post in the URL field why that's a problem, and how to address the issue, but in general, you don't want maintainer-mode rebuild during compile phase, especially since it can cause multiple run of econf.

The causes of maintainer-mode rebuild are various, but most likely it's because of a patch that changes Makefile.am or configure.ac/in and don't rebuild autotools properly. The way to fix this is almost always to inherit autotools eclass and run eautomake/eautoreconf (as needed; eautoconf should only be used when automake is not involved, which is not the case here) during src_unpack phase.

Thanks,
Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-10-30 09:19:47 UTC
Created attachment 252555 [details]
Build log
Comment 2 Andrey Grozin gentoo-dev 2010-10-31 17:01:58 UTC
I don't understand why make in src decided to re-generate src/Makefile again. eautoreconf at the end of src_prepare has already done so.
Comment 3 François Bissey 2011-02-15 21:45:50 UTC
And in 5.23.2 it now complains about share/Makefile but not src/Makefile anymore. I am wondering if it is because Makefile generation is controlled by AC_OUTPUT rather than AC_CONFIG_SUBDIRS. A clue who be handy at this stage.

I wonder if the fact that all the texinfo files are rebuilt in 5.23.2 (when they shouldn't) is related. 
Comment 4 François Bissey 2011-02-16 01:18:41 UTC
Maxima is in poor shape before being patched. In an out of portage install I got this message:

make[1]: Entering directory `/home/fbissey/sandbox/maxima-5.23.2/share'
 cd .. && /bin/sh /home/fbissey/sandbox/maxima-5.23.2/missing --run automake-1.9 --gnu  share/Makefile
Useless use of /d modifier in transliteration operator at /usr/share/automake-1.9/Automake/Wrap.pm line 60.
configure.in:5: version mismatch.  This is Automake 1.9.6,
configure.in:5: but the definition used by this AM_INIT_AUTOMAKE
configure.in:5: comes from Automake 1.9.2.  You should recreate
configure.in:5: aclocal.m4 with aclocal and run automake again.
WARNING: `automake-1.9' is probably too old.  You should only need it if
         you modified `Makefile.am', `acinclude.m4' or `configure.in'.
         You might want to install the `Automake' and `Perl' packages.
         Grab them from any GNU archive site.
 cd .. && /bin/sh ./config.status share/Makefile 
config.status: creating share/Makefile

I tried to add a variety of eaclocal and eautomake before eautoreconf in src_prepare but it just doesn't want to go away.
Comment 5 François Bissey 2011-02-16 09:02:38 UTC
very simple solution!
	epatch "${FILESDIR}"/${P}-emacs-version.patch
	rm share/Makefile.in

	eautoreconf

The makefile.in is then regenerated correctly and the QA warning gone.
Comment 6 Sébastien Fabbro (RETIRED) gentoo-dev 2011-02-17 17:53:37 UTC
Should be fixed by now. Thanks Francois.