Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 341999 - xcb-proto-1.6 requires a negative value fix
Summary: xcb-proto-1.6 requires a negative value fix
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo X packagers
Keywords: InVCS
Depends on: 344887
Blocks: 344827
  Show dependency tree
Reported: 2010-10-21 11:06 UTC by Account removed
Modified: 2010-12-04 15:25 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

x11-apps/xwininfo/xwininfo-1.1.0-r2.ebuild (xwininfo-1.1.0-r2.ebuild,685 bytes, text/plain)
2010-10-21 11:06 UTC, Account removed
xwininfo/files/1.1.0-fix-negative.patch (1.1.0-fix-negative.patch,472 bytes, patch)
2010-10-21 11:07 UTC, Account removed
Details | Diff
x11-proto/xcb-proto/xcb-proto-1.6-r1.ebuild (xcb-proto-1.6-r1.ebuild,1.07 KB, text/plain)
2010-10-21 17:59 UTC, Account removed
xcb-proto/files/1.6-fix-negative.patch (1.6-fix-negative.patch,499 bytes, patch)
2010-10-21 17:59 UTC, Account removed
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Account removed 2010-10-21 11:06:08 UTC
xwininfo-1.1.0-r1 produces wrong value for window left outside of the screen.
it gives a positive value of 65xxx where it should be a negative value
1.0.5 doesn't have this problem.

reported upstream - fix attatched.

Reproducible: Always

Steps to Reproduce:
1. move a window particularly left outside of the screen
2. xwininfo and click that window

Actual Results:  
the output of f.e. Absolute upper-left X is positive

Expected Results:  
the output of f.e. Absolute upper-left X should be negative

problem reported upstream
patch from jcristau attached
Comment 1 Account removed 2010-10-21 11:06:52 UTC
Created attachment 251433 [details]

updated ebuild using the patch
Comment 2 Account removed 2010-10-21 11:07:19 UTC
Created attachment 251435 [details, diff]

jcristau's patch to fix the bug
Comment 3 dottedmag 2010-10-21 11:35:55 UTC
Note it's not a fix, it's a workaround. Proper fix would be to change types in xcb-proto.
Comment 5 Account removed 2010-10-21 17:43:54 UTC
thank you for the quick fix!
it doesn't seem to work though for me.
I rebuilt xcb-proto-1.6 with your patch and afterwards rebuilt xwininfo
without  the workaround patch.
the value is still positive - 
Absolute upper-left X:  64247
in the test case.
is there anything else I should rebuild?
Comment 6 dottedmag 2010-10-21 17:51:26 UTC
All libxcb* libraries, they are generated from xcb-proto.
Comment 7 dottedmag 2010-10-21 17:51:36 UTC
And then xwininfo again.
Comment 8 Account removed 2010-10-21 17:56:36 UTC
wow you're damn fast! :)
I rebuilt libxcb, xcb-util and unpatched =xwininfo-1.1.0-r1 from portage
and it works!
thank you very much! :)
Comment 9 Account removed 2010-10-21 17:59:27 UTC
Created attachment 251465 [details]

updated xcb-proto ebuild using proper patch
Comment 10 Account removed 2010-10-21 17:59:53 UTC
Created attachment 251467 [details, diff]

the proper patch
Comment 11 Joakim Tjernlund 2010-11-09 14:19:06 UTC
Guys, this bug causes double virtual screen size for
me from time to time. The attached fix in this bug fixes this problem.
It needs to go in sooner than later I think 
Comment 12 Paolo Pedroni 2010-11-10 10:02:47 UTC
This is fixed in xwininfo-1.1.1, xwininfo-1.1.0 is not even in portage anymore.
Comment 13 Account removed 2010-11-10 10:14:52 UTC
although xwininfo is fixed, the actual bug is in xcb-proto (see #3 + #4).
Comment 14 Tomáš Chvátal (RETIRED) gentoo-dev 2010-12-04 12:47:49 UTC
Added into main tree. Thanks for report and sorry for delay.
Comment 15 Nikos Chantziaras 2010-12-04 15:25:57 UTC
Affected packages should probably be revbumped.  The proto does nothing on its own, so people will not get the fix until they rebuild manually.