Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 340707 - dev-util/strace-4.5.20-r1 fails under et_EE locale
Summary: dev-util/strace-4.5.20-r1 fails under et_EE locale
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Diego Elio Pettenò (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-12 15:54 UTC by Priit Laes (IRC: plaes)
Modified: 2010-11-21 23:09 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Priit Laes (IRC: plaes) 2010-10-12 15:54:03 UTC
The 'linux/ioctlent.sh' that build is using, uses [A-Z] regexps that will fail with some alphabets like Estonian language:

[snip]
>>> Compiling source in /var/tmp/portage/dev-util/strace-4.5.20-r1/work/strace-4.5.20 ...
make 
/bin/sh linux/ioctlent.sh /usr/include asm
Looking for AGPIOC_BASE
AGPIOC_BASE is a #define
Looking for CCISS_IOC_MAGIC
CCISS_IOC_MAGIC is a #define
Looking for CM_IOC_MAGIC
CM_IOC_MAGIC is a #define
Looking for MGSL_MAGIC_IOC
MGSL_MAGIC_IOC is a #define
x86_64-pc-linux-gnu-gcc -march=native -ggdb -O2 -pipe -Wl,-O1 -Wl,--as-needed -I. -I/usr/include  \
	  -o ioctlsort linux/ioctlsort.c
In file included from linux/ioctlsort.c:20:
./ioctls.h:123: error: ‘PP_IOCTL’ undeclared here (not in a function)
make: *** [ioctlsort] Error 1
emake failed
[/snip]
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-10-13 00:57:58 UTC
Oh sh♥t…
Comment 2 SpanKY gentoo-dev 2010-10-13 02:16:23 UTC
ioctlsort shouldnt be used in the ebuild ...
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-10-13 02:42:16 UTC
It's needed if you wish to strace more recent ioctl()s that are not supported by strace out-of-the-box.

Try debugging an ALSA-based software with strace without rebuilding the ioctl list and you'll know.
Comment 4 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-10-13 02:42:59 UTC
BTW I'll fix this up tomorrow, tonight I'm just too tired to do something sane, I broke it, I'll fix it → thus why the bug is assigned to me.
Comment 5 SpanKY gentoo-dev 2010-10-13 03:05:27 UTC
except ioctlsort does not generate a complete list (nor can it), nor does the single header you're changing affect all arches.  simply patch in the few ioctls you're missing instead of mucking with this hack script.  it is meant purely as reference material.
Comment 6 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-11-17 23:55:16 UTC
Finally fixed this since -r2 applies the new ioctl() as a patch.
Comment 7 SpanKY gentoo-dev 2010-11-21 23:09:50 UTC
for future reference, do not add `die` to `dodoc` calls