Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bugzilla DB migration completed. Please report issues to Infra team via email via infra@gentoo.org or IRC
Bug 337365 - media-radio/xastir _FORTIFY_SOURCE indicates presence of overflow
Summary: media-radio/xastir _FORTIFY_SOURCE indicates presence of overflow
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Thomas Beierlein
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: fortify-source
  Show dependency tree
 
Reported: 2010-09-14 21:21 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2010-09-24 17:51 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (xastir-1.9.8:20100913-163111.log,65.62 KB, text/plain)
2010-09-14 21:22 UTC, Diego Elio Pettenò (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-09-14 21:21:51 UTC
You're receiving this bug because the package in Summary has produced _FORTIFY_SOURCE related warnings indicating the presence of a sure overflow in a static buffer.

Even though this is not always an indication of a security problem it might even be. So please check this out ASAP.

By the way, _FORTIFY_SOURCE is disabled when you disable optimisation, so don't try finding out the cause using -O0.

Thanks,
Your friendly neighborhood tinderboxer
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-09-14 21:22:05 UTC
Created attachment 247356 [details]
Build log
Comment 2 Thomas Beierlein gentoo-dev 2010-09-20 16:17:30 UTC
Looks like an false positive. The code in question is:

rac_record racdata;
...
rc = fgets((char *)&racdata, sizeof(racdata), fdb);

That looks perfectly legal to me, but the __bos macro seems to get the size of the buffer wrong (counting the struct members and checking sizeof() gives the same value as used by the program - 480).

Any idea to give the compiler a simple hint about the size of the buffer?
Comment 3 Thomas Beierlein gentoo-dev 2010-09-24 17:51:58 UTC
+*xastir-1.9.8-r1 (24 Sep 2010)
+
+  24 Sep 2010; Thomas Beierlein <tomjbe@gentoo.org> +xastir-1.9.8-r1.ebuild,
+  +files/xastir-1.9.8-fortify.diff:
+  Fix for bug #337365 (Thanks Diego for reporting) and fix installdir for
+  doc files
+