Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 33714 - speedfreq init script does not honour SPEEDFREQ_USERS flag in /etc/conf.d/speedfreq
Summary: speedfreq init script does not honour SPEEDFREQ_USERS flag in /etc/conf.d/spe...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: SpanKY
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-17 15:51 UTC by Martin Aspeli
Modified: 2003-11-17 23:08 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Fixed /etc/init.d/speedfreq (speedfreq,1.07 KB, text/plain)
2003-11-17 16:01 UTC, Martin Aspeli
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aspeli 2003-11-17 15:51:12 UTC
The SPEEDFREQ_USERS variable set in /etc/conf.d/speedfreq is presumably meant to
turn the "-u" option to speedfreqd on or off when this is executed in the
/etc/init.d/speedfreq init script. However, the init script does not check his
variable. I've included a fix below, though I'm sure a more elegant solution
would be possible.

Reproducible: Always
Steps to Reproduce:
1. Set SPEEDFREQ_USERS="yes" in /etc/conf.d/speedfreq
2. Run /etc/init.d/speedfreq start (or restart)
3. Run "speedfreq -p <profile>" as a normal user.

Actual Results:  
Non-root users are forbidden from changing the speed profile using the speedfreq
client command.

Expected Results:  
Non-root users should be permitted to change the speed profile using speedfreq
if SPEEDFREQ_USERS="yes" is set in /etc/conf.d/speedfreq.
Comment 1 Martin Aspeli 2003-11-17 16:01:04 UTC
Created attachment 20886 [details]
Fixed /etc/init.d/speedfreq

This seems to fix the problem on my machine; of course, a more elegant solution
may be possible.
Comment 2 SpanKY gentoo-dev 2003-11-17 23:08:24 UTC
i removed the SPEEDFREQ_USERS variable and added a SPEEDFREQ_OPTS variable

the user can put whatever they want into that