Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 336603 - games-roguelike/scourge _FORTIFY_SOURCE indicates presence of overflow
Summary: games-roguelike/scourge _FORTIFY_SOURCE indicates presence of overflow
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: fortify-source
  Show dependency tree
 
Reported: 2010-09-09 14:45 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2010-09-11 06:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (scourge-0.21.1:20100909-110203.log,158.33 KB, text/plain)
2010-09-09 14:45 UTC, Diego Elio Pettenò (RETIRED)
Details
Patch to scourge-0.21.1.ebuild to add a sed to fix the overflow (scourge-0.21.1.ebuild.patch,422 bytes, patch)
2010-09-11 05:23 UTC, Kevin Pyle
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-09-09 14:45:03 UTC
You're receiving this bug because the package in Summary has produced _FORTIFY_SOURCE related warnings indicating the presence of a sure overflow in a static buffer.

Even though this is not always an indication of a security problem it might even be. So please check this out ASAP.

By the way, _FORTIFY_SOURCE is disabled when you disable optimisation, so don't try finding out the cause using -O0.

Thanks,
Your friendly neighborhood tinderboxer
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-09-09 14:45:21 UTC
Created attachment 246599 [details]
Build log
Comment 2 Kevin Pyle 2010-09-11 05:23:38 UTC
Created attachment 246798 [details, diff]
Patch to scourge-0.21.1.ebuild to add a sed to fix the overflow

The upstream code declares char tmp[255], then tells snprintf that the buffer is 256 characters long.  The sed fixes it to use sizeof(tmp) in the call to snprintf.
Comment 3 Mr. Bones. (RETIRED) gentoo-dev 2010-09-11 06:58:18 UTC
Fixed in portage.  Thanks for the patch.