Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 33589 - bootsplash errors in init scripts
Summary: bootsplash errors in init scripts
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Troy Dack
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-16 02:15 UTC by Ben Ford
Modified: 2004-01-09 06:19 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Comment incorrect calls, add progress bar handling (functions.sh) (functions.sh.diff,1.10 KB, patch)
2003-12-07 22:25 UTC, Tony Vroon (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Ford 2003-11-16 02:15:54 UTC
Running kernel 2.6.0-test9 patched with bootsplash version 3.1.2, bootsplash
ebuild 0.6-r2 and baselayout 1.8.6.12.

When the system boots in silent mode, no updates are seen on the screen.  The
progress bar doesn't move and the init messages never print.

When it is switched to verbose mode, you can see why.  There are useage messages
printed out for /sbin/splash as each script executes.

The problem is that the init scripts (functions.sh, in function splash_update)
call /sbin/splash "${myscript}" "${action}" when in fact it should be calling a
helper script that calls fbtruetype to print the message and echos a value into
/proc/splash to update the progress bar.  /sbin/splash is only called to set the
theme for the console or to add themes to an initrd.

Reproducible: Always
Steps to Reproduce:
1.  Install patched kernel
2.  merge bootsplash
3.  boot.
Comment 1 Tony Vroon (RETIRED) gentoo-dev 2003-12-07 22:25:56 UTC
Created attachment 21847 [details, diff]
Comment incorrect calls, add progress bar handling (functions.sh)

This patch activates the progress bar.
All variables needed are already in there, but somehow the call is never done.

It also comments the incorrect calls done to the splash tool, which doesn't
know what to do (and floods the logs with messages about that).

In my opinion, this is the first step towards making splash=silent workable for
Gentoo users. I have had fbtruetype calls in place, but there is no way to
erase text put on the screen (at least, none that I've found), so, that's
something for later.
Comment 2 Max Loparev 2003-12-18 07:48:40 UTC
Tony, I applied your patch but still have not progress bar and getting usage messages after each service when switching to verbose mode with F2...

there is one more place with /sbin/splash, it is rc_splash() function
Comment 3 Max Loparev 2003-12-20 01:59:13 UTC
Oops, sorry.
I don't know why, but my functions.sh was not a symlink to /sbin and i patched useless file...

now progress bar working fine. thanks a lot.
Comment 4 Tony Vroon (RETIRED) gentoo-dev 2003-12-20 04:58:18 UTC
Okay, glad to hear it works for you.
I'm working on animation support and the "Press F2 for verbose boot" message, but I'm not attaching any patches until that works flawlessly.
Comment 5 Roman Kreisel 2003-12-21 10:32:20 UTC
I can confirm this patch works, too (well, i didn't apply it using patch but typed the things in the functions.sh using vim *g*)
Comment 6 Martin Allchin 2004-01-04 10:21:27 UTC
Confirmation this patch worked for me :)

Just as a side-note, the file to patch is /sbin/functions.sh and *not* /etc/init.d/functions.sh; this should be a symlink like so:

ln -sf /sbin/functions.sh /etc/init.d/functions.sh
Comment 7 Clark Torgerson 2004-01-05 23:24:12 UTC
Patch worked perfectly for me also! Thanks!
Comment 8 Troy Dack 2004-01-09 06:19:41 UTC
bootsplash-0.6-r3 has been committed to CVS.

It should solve these issues and shouldn't require patching of functions.sh (there are already splash functions in baselayout).

See Bug #21019 for more info.

Sorry for the delay in getting this fixed.