Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 335021 - Regenerate use.local.desc on rsync level instead of CVS, using egencache
Summary: Regenerate use.local.desc on rsync level instead of CVS, using egencache
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Infrastructure
Classification: Unclassified
Component: Git (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Infrastructure
URL:
Whiteboard:
Keywords:
Depends on: 346819
Blocks:
  Show dependency tree
 
Reported: 2010-08-28 14:38 UTC by Michał Górny
Modified: 2011-02-04 19:52 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-08-28 14:38:03 UTC
As of 2010-08-27, egencache is able to regenerate use.local.desc file as well as the metadata, using the additional '--update-use-local-desc' action. Our tests show that it performs better than the current scripts, especially in handling whitespace; besides that, it is able to regenerate the gx86 use.local.desc file correctly within near 10 seconds.

AFAIK, egencache is already used on the rsync machine in order to regenerate the package metadata. Thus, after upgrading portage there to a version supporting the new features, I think it would be a nice step forward to move the use.local.desc regeneration there through adding '--update-use-local-desc' to the current egencache call.
Comment 1 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-08-28 15:16:47 UTC
And what version of portage is required for this feature?
Comment 2 Alec Warner (RETIRED) archtester gentoo-dev Security 2010-08-28 20:35:26 UTC
The code I wrote was mostly a giant hack to get it done; so if egencache is better at it I am all for it :)  The current code is chillin in cvs:

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo/users/antarus/projects/infra/

I think the comments preservation is a decent feature, if we could keep that in whatever we migrate to that would be nice ;)
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-08-28 21:33:28 UTC
(In reply to comment #1)
> And what version of portage is required for this feature?

Currently, -9999. Zac promised to sneak it into 2.1.9.

(In reply to comment #2)
> I think the comments preservation is a decent feature, if we could keep that in
> whatever we migrate to that would be nice ;)

Will be done in a while.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-08-28 21:39:31 UTC
Ah, and 2.2_rc70+ have this feature too but complete comment saving with be with _rc72+ (it now simply uses a short, hard-coded comment).
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-09-06 18:51:53 UTC
I've retested with portage-2.1.9, and:
$ egencache --update-use-local-desc --preserve-comments --repo=gentoo
does the job fine.
Comment 6 solar (RETIRED) gentoo-dev 2010-09-12 02:56:40 UTC
If this bug suggests to move making the end user create the use.local.desc then it's a no go. metadata.xml is allowed to be rsync excluded by the end user.
Comment 7 Alec Warner (RETIRED) archtester gentoo-dev Security 2010-09-12 03:18:12 UTC
Currently a cronjob updates use.local.desc and checks it into CVS.

I believe the bug proposes that we switch to running egencache at the same time that we generate metadata (on osprey?)

-A
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-09-12 07:43:23 UTC
(In reply to comment #7)
> I believe the bug proposes that we switch to running egencache at the same time
> that we generate metadata (on osprey?)

Yep, that's the idea. Or, to be more concise, using the same egencache call and adding additional arguments to it to enable the use.local.desc generation.
Comment 9 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-12-18 11:35:10 UTC
Ping. Portage-2.1.9 is now stable on almost all arches, so I think we could proceed with the switch.
Comment 10 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2010-12-19 00:52:13 UTC
mgorny:
Can you update for the full commandline/env settings to use a specific (non-root) make.conf and specific dir for $PORTDIR for this, then we can update osprey and drop the old file from CVS.
Comment 11 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-12-19 10:03:38 UTC
(In reply to comment #10)
> mgorny:
> Can you update for the full commandline/env settings to use a specific
> (non-root) make.conf and specific dir for $PORTDIR for this, then we can update
> osprey and drop the old file from CVS.

Hm, I guess that would be:

egencache --config-root $LOCATION \
    --portdir $PORTDIR \
    --update --jobs $NJOBS --rsync \
    --update-use-local-desc --preserve-comments

Where $LOCATION would be the alternate root, and make.conf would be read from $LOCATION/etc/make.conf then (or $LOCATION/etc/portage/make.conf, whichever you prefer). I've added the '--rsync' option but dependending on the particular scenario, it may be not needed. And the new use.local.desc would be in $PORTDIR/profiles (like usual); if you want an alternate location, you can use '--use-local-desc-output $ALTPATH'.

And just to make it clear, the following command updates both the metadata cache and the use.local.desc file.
Comment 12 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2011-01-08 02:42:42 UTC
this change is now in the "new" mastermirror code that I have been working on. Not yet used, but running. Will be deployed soonish.
Comment 13 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2011-02-04 19:52:21 UTC
(In reply to comment #12)
> this change is now in the "new" mastermirror code that I have been working on.
> Not yet used, but running. Will be deployed soonish.
> 

FYI, deployed.