33495 – hping build doesn't honour debug or nostrip

Bug 33495 - hping build doesn't honour debug or nostrip

Summary: hping build doesn't honour debug or nostrip

Status:	VERIFIED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All All

Importance:	High minor (vote)
Assignee:	Jon Portnoy (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2003-11-14 16:40 UTC by Thomas R. (TRauMa)
Modified:	2006-01-21 10:36 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Patch for hping-2.0.0_rc2.ebuild (tmp.patch,630 bytes, patch) 2003-11-14 16:43 UTC, Thomas R. (TRauMa)	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Thomas R. (TRauMa) 2003-11-14 16:40:35 UTC

After playing aroung with hping I noticed that it get's build with debug flag and stripped afterwards, which really makes no sense. So I cleaned up.

Comment 1 Thomas R. (TRauMa) 2003-11-14 16:43:57 UTC

Created attachment 20756 [details, diff]
Patch for hping-2.0.0_rc2.ebuild

Comment 2 Jon Portnoy (RETIRED) gentoo-dev

2003-11-20 11:49:06 UTC

Fixed, thanks.

Comment 3 Thomas R. (TRauMa) 2003-12-19 10:37:47 UTC

Sorry, but the hping-2.0.0_rc-r1.ebuild in the tree still has this bug, there is some nonesense in it:

# $Header: /home/cvsroot/gentoo-x86/net-analyzer/hping/hping-2.0.0_rc2-r1.ebuild,v 1.3 2003/12/18 22:34:40 gmsoft Exp $

[...]

src_compile() {
	epatch ${FILESDIR}/wlan-header-fix.patch

	./configure || die

	if [ `use debug` ]
	then
		make CCOPT="${CFLAGS}" || die
	else
		make CCOPT="${CFLAGS}" || die
	fi
}

That's wrong, the second make should have DEBUG="" as an option.

Comment 4 Jon Portnoy (RETIRED) gentoo-dev

2003-12-19 10:48:25 UTC

Sorry. Brainfsck, I guess 8)

Fixed now.

Comment 5 Thomas R. (TRauMa) 2006-01-21 10:36:22 UTC

mass cleaning my bugs