331973 – app-crypt/mcrypt-2.6.8 fails to on OSX prefix due to inclusion of <malloc.h>

Bug 331973 - app-crypt/mcrypt-2.6.8 fails to on OSX prefix due to inclusion of <malloc.h>

Summary: app-crypt/mcrypt-2.6.8 fails to on OSX prefix due to inclusion of <malloc.h>

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	x86 OS X

Importance:	High normal (vote)
Assignee:	Robin Johnson

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	prefix-gx86
	Show dependency tree

Reported:	2010-08-10 03:58 UTC by Mark Kowarsky (RETIRED)
Modified:	2010-08-10 18:01 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Patch to correct malloc.h -> stdlib.h (mcrypt-malloc.patch,278 bytes, patch) 2010-08-10 03:59 UTC, Mark Kowarsky (RETIRED)	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mark Kowarsky (RETIRED) gentoo-dev

2010-08-10 03:58:20 UTC

In attempting to install mcrypt on a prefixed Gentoo system, it failed due to malloc.h not being found. malloc.h is not included in OSX (and I believe other BSDs) and it should not be used (as it is not a POSIX header). Instead stdlib.h should be used.

Attached is a patch to fix the package.

Reproducible: Always

Steps to Reproduce:

Comment 1 Mark Kowarsky (RETIRED) gentoo-dev

2010-08-10 03:59:56 UTC

Created attachment 242191 [details, diff]
Patch to correct malloc.h -> stdlib.h

Added patch to fix src/rfc2440.c in mcrypt.

Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester

2010-08-10 15:22:17 UTC

If work is being done here for Gentoo Prefix stuff.. then let's move libmcrypt to gx86 too :)

for libmcrypt: s/elibtoolize/eautoreconf/ and add keywords: http://overlays.gentoo.org/proj/alt/browser/trunk/prefix-overlay/dev-libs/libmcrypt/libmcrypt-2.5.8-r1.ebuild
for mcrypt: No changes but this patch addition. add keywords

Neither need EAPI bumps, unless desired for ebuild writing simplicity.

I can do it if you would like, revbumps?

Comment 3 Robin Johnson archtester

2010-08-10 15:31:00 UTC

darkside: +1 on commit.

Comment 4 Jeremy Olexa (darkside) (RETIRED) archtester

2010-08-10 18:01:05 UTC

done, thx Mark