Bug 329897 – Stabilise app-text/adiff-1.4

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Sebastian Dörner 2010-07-26 11:18:57 UTC]

Please stable app-text/adiff-1.4.
In tree since 2008.
No bugs in 2010.

Reproducible: Always

Steps to Reproduce:

[Comment 1 Jeroen Roovers (RETIRED) 2010-07-26 11:23:49 UTC]

Please don't do that.

[Comment 2 Jeroen Roovers (RETIRED) 2010-07-26 11:40:40 UTC]

Arch teams, please test and mark stable:
=app-text/adiff-1.4
Target KEYWORDS="alpha amd64 ia64 ppc64 x86"

[Comment 3 Dane Smith (RETIRED) 2010-07-26 11:48:31 UTC]

Tested x86. One tiny oddity: 
unpack adiff-1.4: file format not recognized. Ignoring.

It doesn't seem to be affecting anything (adiff seems to be working just fine), and I'm not quite sure what's generating it. Assuming this is expected, should be ok to stable on x86.

[Comment 4 Jeroen Roovers (RETIRED) 2010-07-26 11:54:51 UTC]

(In reply to comment #3)
> Tested x86. One tiny oddity: 
> unpack adiff-1.4: file format not recognized. Ignoring.

That's a problem with the unpack() function (it expects tarballs, compressed or not) that is worked around by copying the file directly from $DISTDIR in src_install().

[Comment 5 Jeroen Roovers (RETIRED) 2010-07-26 11:58:39 UTC]

(In reply to comment #3)
> Tested x86. One tiny oddity: 
> unpack adiff-1.4: file format not recognized. Ignoring.

Trivially fixed in CVS.

--- adiff-1.4.ebuild    5 Apr 2010 21:32:34 -0000       1.4
+++ adiff-1.4.ebuild    26 Jul 2010 11:56:50 -0000
@@ -18,6 +18,11 @@
 
 S=${WORKDIR}
 
+src_unpack() {
+       # Nothing to unpack
+       :
+}
+
 src_compile() {
        pod2man --release=${PV} --center="${HOMEPAGE}" \
                --date="2007-12-11" "${DISTDIR}"/${P} ${PN}.1 || die

[Comment 6 Christian Faulhammer (RETIRED) 2010-07-26 13:48:51 UTC]

stable x86, thanks Dane and Jer

[Comment 7 Markos Chandras (RETIRED) 2010-07-31 22:08:58 UTC]

amd64 done

[Comment 8 Raúl Porcel (RETIRED) 2010-08-28 16:42:00 UTC]

alpha/ia64 stable

[Comment 9 Brent Baude (RETIRED) 2010-12-28 15:34:25 UTC]

ppc64 stable, closing