Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 328939 - mail-filter/spamassassin-3.3.1-r2 - warning messages after upgrade to dev-lang/perl-5.12.1
Summary: mail-filter/spamassassin-3.3.1-r2 - warning messages after upgrade to dev-lan...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Gentoo Perl team
URL:
Whiteboard:
Keywords:
: 343631 (view as bug list)
Depends on:
Blocks: perl-5.12.1
  Show dependency tree
 
Reported: 2010-07-19 11:56 UTC by Nico R.
Modified: 2010-11-01 08:29 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
spamassassin-3.3.1-PERL-5-12.patch (spamassassin-3.3.1-PERL-5-12.patch,9.76 KB, text/plain)
2010-07-20 20:14 UTC, David Abbott (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nico R. 2010-07-19 11:56:37 UTC
After upgrading to perl-5.12.1, I see three new messages in fetchmail.log on that host for each received mail (mails are piped through spamassassin (from mail-filter/spamassassin-3.3.1-r2) by procmail).


This messages appears for each mail, after starting spamassassin:

defined(%hash) is deprecated at /usr/lib/perl5/vendor_perl/5.12.1/Mail/SpamAssassin/Dns.pm line 757.
        (Maybe you should just omit the defined()?)


The following message appears 36 times for each spamassassin run:

[date and time] [PID] warn: Use of "goto" to jump into a construct is deprecated at /usr/lib/perl5/vendor_perl/5.12.1/Mail/SpamAssassin/Plugin/Check.pm line 409.


This message only appears for a few mails:

[date and time] [PID] warn: Use of uninitialized value in lc at /usr/lib/perl5/vendor_perl/5.12.1/Mail/SpamAssassin/Plugin/MIMEEval.pm line 501.


Spamassassin still works, but the messages seem to indicate that there is something wrong; and the mass of messages is filling up my log file.
Comment 1 David Abbott (RETIRED) gentoo-dev 2010-07-19 16:41:11 UTC
These bugs are known upstream and to be fixed with the release of 3.3.2

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6392
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6396
Comment 2 David Abbott (RETIRED) gentoo-dev 2010-07-20 20:14:46 UTC
Created attachment 239599 [details]
spamassassin-3.3.1-PERL-5-12.patch

Unified patch applied fine, I did not test fully. 
The only patch not include;
Index: rulesrc/sandbox/jm/EmailBL.pm
===================================================================
--- rulesrc/sandbox/jm/EmailBL.pm	(revision 930024)
+++ rulesrc/sandbox/jm/EmailBL.pm	(working copy)
@@ -307,7 +307,7 @@
 sub _lookup {
     my ($self, $pms, $prs, $emails) = @_;
 
-    return 0 unless defined @$emails;
+    return 0 unless @$emails;
 
     my %digests = map { md5_hex($_) => $_ } @$emails;
     my $dcnt = scalar keys %digests;
Comment 3 David Abbott (RETIRED) gentoo-dev 2010-07-21 06:07:39 UTC
Nico, I added the patchset to;
perl-experimental [Git] (git://git.o.g.o/proj/perl-overlay....)
overlay if you could test it that would be super
http://git.overlays.gentoo.org/gitweb/?p=proj/perl-overlay.git;a=commit;h=e3d3f1285b1b68f9ff3fa350ed47a0a3673de801
Comment 4 Nico R. 2010-07-21 07:28:52 UTC
David, mail-filter/spamassassin-3.3.1-r3 from the perl-experimental overlay you mentioned in comment 3 fixes this bug for me.

Thank you!
Comment 5 David Abbott (RETIRED) gentoo-dev 2010-07-21 08:34:00 UTC
(In reply to comment #4)
> David, mail-filter/spamassassin-3.3.1-r3 from the perl-experimental overlay you
> mentioned in comment 3 fixes this bug for me.
> 
> Thank you!
> 
Your welcome, seems to be ok here also, I am testing on v5.10.1 (*) built for x86_64-linux.
Comment 6 Torsten Veller (RETIRED) gentoo-dev 2010-08-15 13:18:44 UTC
So can I add the patch to the tree?
Comment 7 David Abbott (RETIRED) gentoo-dev 2010-08-15 13:54:18 UTC
(In reply to comment #6)
> So can I add the patch to the tree?
> 
Yes, thanks Torsten :)
Comment 8 Torsten Veller (RETIRED) gentoo-dev 2010-08-15 15:18:59 UTC
Fixed in 3.3.1-r3. Thanks
Comment 9 Torsten Veller (RETIRED) gentoo-dev 2010-11-01 08:29:51 UTC
*** Bug 343631 has been marked as a duplicate of this bug. ***