Bug 326117 – dev-util/telepathy-inspector: Verify and potentially improve Python-related code

• Status: RESOLVED WONTFIX
• Product: Gentoo Linux

[Description Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-06-29 07:21:58 UTC]

- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml

[Comment 1 Florian Eitel 2011-10-05 09:22:17 UTC]

Can confirm this. Patch attached.

[Comment 2 Florian Eitel 2011-10-05 09:22:38 UTC]

Created attachment 288837 [details]
patch for telepathy-inspector-0.5.3.ebuild

[Comment 3 Arfrever Frehtes Taifersar Arahesis 2011-10-05 20:08:23 UTC]

(In reply to comment #2)

PYTHON_DEPEND="2" should be set before inheriting python.eclass.
dev-lang/python should be removed from DEPEND.

[Comment 4 Arfrever Frehtes Taifersar Arahesis 2011-10-05 20:09:45 UTC]

(In reply to comment #3)
> PYTHON_DEPEND="2" should be set before inheriting python.eclass.
> dev-lang/python should be removed from DEPEND.

If Python is needed only at build time, then PYTHON_BDEPEND="2" could be set...

[Comment 5 Ian Delaney (RETIRED) 2011-11-13 12:25:29 UTC]

Created attachment 292389 [details, diff]
ebuild patch

Needs [2], tested with {2.6 2.7 3.1 3.2}.
bumped to EAPI as usual.  all aok.

[Comment 6 Arfrever Frehtes Taifersar Arahesis 2011-11-14 18:06:15 UTC]

Rather use DEPEND="... =dev-lang/python-2* ..." instead of PYTHON_DEPEND (until PYTHON_BDEPEND can be used).

[Comment 7 Ian Delaney (RETIRED) 2011-11-18 19:25:58 UTC]

Created attachment 293017 [details, diff]
r

[Comment 8 Arfrever Frehtes Taifersar Arahesis 2011-11-20 06:30:55 UTC]

(In reply to comment #7)

Don't change DESTDIR="${D}" to DESTDIR="${ED}".

[Comment 9 Ian Delaney (RETIRED) 2011-11-21 15:08:16 UTC]

Created attachment 293331 [details, diff]
revised ebuild patch

[Comment 10 Pacho Ramos 2012-10-06 14:09:17 UTC]

Probably we should treeclean this:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=670553

[Comment 11 Pacho Ramos 2012-12-25 13:15:40 UTC]

dropped