Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 325615 - x11-plugins/wmhdplop doesn't work on 64-bit
Summary: x11-plugins/wmhdplop doesn't work on 64-bit
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Dockapp Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-25 21:54 UTC by Mikael Magnusson
Modified: 2010-06-29 15:52 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
fix (wmhdplop-0.9.9-64bit.patch,3.86 KB, patch)
2010-06-25 21:55 UTC, Mikael Magnusson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Magnusson 2010-06-25 21:54:46 UTC
#92519 isn't totally true, it actually doesn't work on 64-bit, after a while (80 days for me) the procstats fields will overflow the signed int field and the hd leds will be permanently on. the problem is using ints instead of longs.
Comment 1 Mikael Magnusson 2010-06-25 21:55:58 UTC
Created attachment 236565 [details, diff]
fix

some of the int->long may or may not be needed, but what the hey.
Comment 2 Bernard Cafarelli gentoo-dev 2010-06-29 09:50:11 UTC
Yes, probably the keywording team did not try running the dockapp for more than 80 days ;)

Thanks for the patch, I've added it in 0.9.9-r1
Comment 3 Mikael Magnusson 2010-06-29 15:52:29 UTC
fwiw the problem isn't fixed by restarting the dockapp, the issue is the numbers in /proc/diskstat no longer fit in a signed int, re the changelog entry. i'll let you know in a couple of million years if it needs to be unsigned long. :)